Conversation
The generated preamble hardcodes HIP_SUPPORTED_ARCHS and forces it into PYTORCH_ROCM_ARCH, so it is the sole gate for which gfx targets a kernel can emit code objects for. A kernel requesting gfx1151 (RDNA 3.5 / Strix Halo) in rocm-archs intersected to an empty set: the build succeeded but emitted no --offload-arch flags, silently shipping a variant with no device code. The Nix toolchain already supports these targets (clr passthru gpuTargets covers gfx1150-gfx1153 in ROCm 7.14, and upstream PyTorch's ROCm wheel arch list added them in 2.10), so the only change needed is the preamble allowlist. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Hi @AzeezIsh, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/huggingface/kernels/blob/main/CONTRIBUTING.md for more details. |
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
gfx1150/gfx1151(RDNA 3.5 — Strix Point / Strix Halo) to the hardcodedHIP_SUPPORTED_ARCHSallowlist in the generated CMake preamble.Without this, a kernel declaring
rocm-archs = ["gfx1151"]inbuild.tomlintersects to an empty set inhip_archs_intersection— the build succeeds but emits no--offload-archflags, silently shipping a published variant containing no device code for the requested target.The toolchain already supports these archs end-to-end:
nix-builderROCm 7.14 clrgpuTargetscoversgfx1150–gfx1153(andgfx1250)gfx1150/gfx1151in 2.10--offload-arch=gfx1151(verified on Strix Halo hardware)Verified the mechanics directly: with the updated list,
hip_archs_intersectionkeepsgfx1151and--offload-arch=gfx1151is emitted per-source; with the old list the kernel's arch set is empty.Notes for reviewers
gfx1102/gfx1103(other RDNA 3 iGPUs) are also absent from the allowlist; left them out to keep this scoped — happy to add if preferred.kernels initscaffold defaultrocm-archslist insrc/init/templates/build.tomlis unchanged — didn't want to expand the default build matrix for new kernels without maintainer input.Context: unblocks a
gfx1151ROCm kernel contribution tracked in huggingface/kernels-community#1149.Test plan
cmake -Pcheck:rocm-archs = ["gfx1151"]surviveship_archs_intersectionagainst the updatedHIP_SUPPORTED_ARCHS(empty before,gfx1151after)torch*-rocm*variant build of a kernel withrocm-archs = ["gfx1151"]producing a gfx1151 code object (needs Nix builder run)Generated with Devin