Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have a couple of kernels for which we open PRs outside of the kernels-community Hub org.
A kernel build usually has two branches to target:
mainIn some cases, we bump the version of a kernel and that means the build is uploaded in a new branch. For uploads to the kernels-community Hub org, this is fine because we have write access to create the requested branches. However, for external repositories, we cannot do this. PRs are valid for existing branches only.
We should error out early in this case to skip the (often extensive) build process for commands like
releaseandmerge-and-upload. I think this is the right design because:kernels-bot build ...first to validate if things are looking good. So, when we ultimately runmerge-and-upload, if we violate the branch conditions for PRs, it makes sense to stop and error out early.