Skip to content

feat: error early when a version branch doesn't exist in external repos. - #1163

Open
sayakpaul wants to merge 4 commits into
mainfrom
error-early-external-repos
Open

sayakpaul wants to merge 4 commits into
mainfrom
error-early-external-repos

Conversation

@sayakpaul

Copy link
Copy Markdown
Member

Currently, we have a couple of kernels for which we open PRs outside of the kernels-community Hub org.

A kernel build usually has two branches to target:

  • main
  • version branch

In some cases, we bump the version of a kernel and that means the build is uploaded in a new branch. For uploads to the kernels-community Hub org, this is fine because we have write access to create the requested branches. However, for external repositories, we cannot do this. PRs are valid for existing branches only.

We should error out early in this case to skip the (often extensive) build process for commands like release and merge-and-upload. I think this is the right design because:

  • Usually, on PRs, we run kernels-bot build ... first to validate if things are looking good. So, when we ultimately run merge-and-upload, if we violate the branch conditions for PRs, it makes sense to stop and error out early.
  • Same applies for the "release" command as well.

@github-actions github-actions Bot added feature New functionality / capability needs-rebase Has merge conflicts with the base branch labels Sep 18, 2026
@danieldk
danieldk requested a review from drbh September 18, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality / capability needs-rebase Has merge conflicts with the base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant