Repository navigation
Don't infer the Harbor builder from unrelated .md and .toml files - #8891
Open
NgoQuocViet2001 wants to merge 1 commit into
Open
NgoQuocViet2001 wants to merge 1 commit into
NgoQuocViet2001 wants to merge 1 commit into
Conversation
Harbor tasks are identified by their task.toml and instruction.md file names, so other Markdown and TOML files like LICENSE.md or pyproject.toml shouldn't count as votes for the harbor module when inferring the builder of a dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #8729,
.mdand.tomlare allowed data file extensions. Every Markdown or TOML file matched by the default**pattern now counts as a vote forharborwhen the builder is inferred. So a directory withdata.jsonl,LICENSE.mdandCHANGELOG.mdis inferred as Harbor, and so isdata.csvwithpyproject.tomlandruff.toml, or a tie likeseqs.fastawithnotes.md.load_dataset(dir)then fails withDataFilesNotFoundError: No task.toml or instruction.md files found. Before #8729, these directories loaded with the json/csv/fasta builders.Harbor tasks are identified by their
task.tomlandinstruction.mdfile names, which are already counted as metadata files. This PR drops the votes of all other.mdand.tomlfiles ininfer_module_for_data_files_list. Harbor repos are still inferred as Harbor. A directory that only contains unrelated.md/.tomlfiles now gets the generic "No (supported) data files found" error instead of the Harbor one.pytest tests/test_load.py tests/test_data_files.py tests/packaged_modules/test_harbor.py -m "not integration": 320 passed, 3 skipped. The 6 new cases fail without the fix.pytest tests/packaged_modules/test_fasta.py tests/test_buckets.py: 53 passed, 4 skippedruff checkandruff format --checkon src, tests, benchmarks and utils are clean