Repository navigation
keep nullable integers intact in to_pandas - #8890
Open
Chessing234 wants to merge 1 commit into
Open
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an int64 column with a null was converted to float64. float64 cannot hold every int64, so
2**62 + 1came back as a different number.to_pandasand the pandas formatter now keep those nulls as missing values, the same wayto_csv/to_json/to_sqlalready do. a column with no nulls stays int64.checked locally:
[2**62 + 1, None, 3]round-trips throughto_pandas(), the batched path, andwith_format("pandas").@lhoestq
Made with Cursor