docs(unit1): fix repetitive wording in 'Image' definition#425
Merged
sergiopaniego merged 2 commits intohuggingface:mainfrom Apr 20, 2026
Merged
docs(unit1): fix repetitive wording in 'Image' definition#425sergiopaniego merged 2 commits intohuggingface:mainfrom
sergiopaniego merged 2 commits intohuggingface:mainfrom
Conversation
Closes huggingface#419. The sentence described an 'Intensity image' but the surrounding paragraph uses 'Image' generically; repeating 'Intensity' makes the clause circular ('intensity images are constrained in their intensity'). Drop the qualifier per the issue suggestion.
SAY-5
requested review from
burtenshaw,
johko,
merveenoyan and
sergiopaniego
as code owners
pcuenca
approved these changes
Apr 17, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sergiopaniego
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #419.
The sentence at
chapters/en/unit1/image_and_imaging/image.mdx:9reads:The paragraph introduces F(X,Y) as a generic image function and discusses the intensity values it takes. Using 'Intensity images' as the subject makes the clause circular ('intensity images are constrained in their intensity'). It also re-scopes the statement to a narrower class of images for no reason — the constraint (non-negative, finite) applies to any image the section has described up to that point.
Aligning with the suggestion in #419, replace 'Intensity images' → 'Images' so the sentence reads naturally and keeps the scope consistent with the rest of the paragraph.