Skip to content

chore: add a justfile for common dev commands - #1096

Open
splusq wants to merge 16 commits into
huggingface:mainfrom
splusq:chore/justfile
Open

splusq wants to merge 16 commits into
huggingface:mainfrom
splusq:chore/justfile

Conversation

@splusq

@splusq splusq commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds a justfile for dependency installation, the test suite, and individual test targets.


Note

Low Risk
Documentation-style tooling only; no runtime, auth, or application logic changes.

Overview
Adds a root justfile so contributors can run standard OpenEnv workflows via just instead of remembering long shell commands.

It sets PYTHONPATH=src:envs, defines just install (uv sync --all-extras), just test (pytest with the same env ignores and -m "not integration and not network and not docker" filters used for local/CI-friendly runs), and just test-one <target> for a single file or pattern. The default recipe lists available commands.

Reviewed by Cursor Bugbot for commit 88f6121. Bugbot is set up for automated code reviews on this repo. Configure here.

Wraps the commands already documented in CLAUDE.md (install, test, lint,
format, docs-sync) so they are discoverable via `just --list` and harder
to get subtly wrong. `just test` mirrors the CI invocation, including the
same --ignore set and marker filter.

Independent of the RFC 005 work; split out so it can land or be dropped
on its own.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@splusq
splusq marked this pull request as ready for review August 31, 2026 21:23

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Reviewed at c3c04f884500e775512795bc08f5655da7038074. The test recipe currently matches the repository workflow, but the PR body promises lint, format, and docs-sync recipes that are absent from the 23-line justfile, and the file lacks a final newline. Please either add the claimed recipes or narrow the description, add the newline, refresh onto current main, and run exact-head CI (only Bugbot has run). No runtime or alignment concern otherwise.

Open in Web View Automation 

Sent by Cursor Automation: Release

@burtenshaw

Copy link
Copy Markdown
Collaborator

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 508d8ef1

Useful ergonomic justfile. The test recipe matches the CLAUDE.md CI-safe invocation (same three --ignore flags; file-level PYTHONPATH propagates). Not wheel cargo.

Nit: missing trailing newline (non-blocking). LGTM.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 3fc52f15 (merge-main only)

Rebased onto main after #1178. Feature tip unchanged from prior review at 58f92f7f (justfile install/test/test-one; final newline fixed). Non-blocking nit still: test-one comment names a stale test_agentic_harness_types.py path.

Root tooling only; not release cargo. Still needs exact-head repository CI.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE @ ac5a7ec5

Addresses the prior nit: test-one example now points at the real tests/core/test_state_schema_subclass.py. Recipes still match the narrowed install/test/test-one scope.

Tooling-only; not 0.6.0 wheel cargo. Exact-head repository CI still needed before merge if workflows are gated.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 357b9fbb (merge-main only)

Rebased onto main after #1219. Feature unchanged: install/test/test-one justfile + corrected test-one example path.

Tooling-only; not wheel cargo.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge-main re-APPROVE at fd2eea6b

Ben merged main into this fork tip. Feature diff unchanged: justfile install/test/test-one recipes only; test-one comment now points at a real path.

Fork PR: repository CI still needs Approve-and-run. Not OpenEnv wheel cargo.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-APPROVE at 31bdf238 (merge-main only)

Ben merged main (26c9465e / #1179) into this fork PR. Stable feature patch-id is unchanged vs prior approved tip fd2eea6b (ef1dafed…); justfile blob identical.

Prior technical approval stands. Still needs maintainer Approve and run. Not 0.6.0 wheel cargo.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Release

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants