Repository navigation
Conversation
Gate native navigation, full-screen Settings, symbol-backed Done, stream controls and resize handling to verified Duo hardware. Preserve upstream non-Duo paths and deployment targets. Add geometry and device-gating regressions with older-SDK guards. Co-Authored-By: Warp <agent@warp.dev>
bradmb
marked this pull request as ready for review
October 26, 2026 21:13
Keep the live stream above active horizontal folds and provide a fitted desktop keyboard below. Add menu-based laptop mode control, left-pane book controls, lifecycle cleanup, and geometry/UIKit regressions. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the iPhone Duo's unique screen layout while keeping the existing experience unchanged for other iPhones and iPads.
Changes:
iPhone19,4), including simulator support. Other devices continue using their existing layouts, and the detection remains consistent when folding or rotating the device.Tabletop / laptop mode
Validation
IPHONEOS_DEPLOYMENT_TARGET=15.0and signing disabled. Xcode 27.1 no longer accepts iOS 14 targets; no deployment-target change was committed. The Xcode 26.3 build validates the unchanged iOS 14 target.sh Tests/run-keyboard-smoke.sh <booted-simulator-udid>on an Apple Silicon Mac.git diff --checkall passed.Notes
This is intentionally limited to the Duo rather than attempting to redesign the application for every iPhone and iPad. Additional Duo hardware identifiers can be added once they're verified.
While the existing non-Duo code paths have been reviewed and regression-tested, I have not physically tested the changes on ordinary iPhones or iPads. That testing would still be useful before merging.
The separate connection diagnostics PR is independent of this work, although both PRs modify some of the same files.
Existing localization build warnings are unrelated to these changes. No personal configuration, provisioning information, screenshots, or build artifacts are included.
Co-Authored-By: Warp agent@warp.dev