Repository navigation
Improve adaptive iPhone layouts and stream viewport resizing - #122
Draft
alessandrococciolo wants to merge 1 commit into
Draft
alessandrococciolo wants to merge 1 commit into
alessandrococciolo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing the stream while zoomed can leave the viewport at its previous size, and the Metal/OpenGL renderers currently only refresh SDK dimensions when the width or scale changes. This updates the complete viewport bounds and makes the surrounding interface fit both narrow and wide windows. The work was motivated by iPhone Duo, with layout decisions based on available space rather than device names or hard-coded screen dimensions.
The upstream app identity, deployment targets, assets, SDK and default video settings are preserved. The iOS 14 picker fallback remains in place.
Validation
git diff --checkpasses.Remaining validation
This is a draft pending a real iPhone Duo streaming session: fold/unfold and rotate while connected, including after pinch zoom, then check pointer alignment, keyboard access and scrolling through the complete stream menu. Login, streaming latency and physical-device behavior have not been tested yet.