fix(periodic-report): accept UTC without tzdata - #4281
Conversation
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
|
@huangruiteng This is the isolated fix for the Windows failure currently present on |
|
@huangruiteng Exact head 3a718ae is now fully green: 23 checks passed and 4 expected skips, including Windows PowerShell, four pytest shards, Stage2C, compatibility, dashboard, DCO, and merge-gate. This 3-file baseline fix unblocks #4233, #4204, and #4133, whose current only substantive CI failure is the same missing-tzdata UTC path. Please prioritize independent review/merge of #4281; after it lands I will resync those three PRs to main and rerun their CI. |
Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
|
@huangruiteng Main advanced to 6ef6838, so #4281 is now synchronized at exact head 89a50b8. The merge was clean; the 3-file diff is unchanged. Revalidation: 45 focused tests, scoped Ruff, full mypy, and git diff --check all passed. Fresh exact-head CI is running. |
|
Closing as superseded by #4263, which is now on main and includes the same canonical UTC-without-tzdata behavior plus a Windows regression test. The current main code already skips external ZoneInfo lookup for UTC, so merging #4281 would duplicate the fix and regress newer periodic-report schedule work. |
Summary
Root cause
The Windows packaged install has no external tzdata package. Validating the built-in UTC periodic-report default through ZoneInfo raised ZoneInfoNotFoundError, so quota should-run failed closed. This is the shared baseline failure currently visible on #4204 and #4133.
Validation