Repository navigation
fix: round SQLite and Presto timestamps to the millisecond they print - #247
Merged
Merged
Conversation
Half a millisecond was truncated, so 12:23:34.9995 was printed as 12:23:34.999.
|
coverage: 96.17% (+0.003%) from 96.167% — SashaMIT:fix/sqlite-millis-round into huandu:master |
Owner
|
Thanks for your contribution! |
Contributor
Author
|
Thanks for merging it. The millisecond SQLite and Presto print is the one the timestamp rounds to now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite and Presto timestamp literals keep three fractional digits, but the value was only rounded by half a microsecond.
12:23:34.1235was printed as12:23:34.123.12:23:34.9995was printed as12:23:34.999. Those flavors now round by half a millisecond.12:23:34.123456789is still12:23:34.123. A MySQL literal still keeps the microseconds:12:23:34.1235and12:23:34.9995.Test plan
TestInterpolateMillisecondRoundfailed on tip (12:23:34.123and12:23:34.999) and passes after the roundTestFlavorInterpolateandgo test ./...