Repository navigation
Only install the release's attached zip when updating - #10
Merged
Merged
Conversation
Use REQUIRE_RELEASE_ASSETS with an everyalt-<version>.zip name filter so the update checker never falls back to GitHub's auto-generated source zip. That zip doesn't include vendor/plugin-update-checker, so installing it would silently end automatic updates on that site. A release published without its zip is now skipped instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The update checker calls
enableReleaseAssets()with the defaultPREFER_RELEASE_ASSETSbehavior. If a release is ever published withouteveryalt-<version>.zipattached (or with a differently named file), it falls back to GitHub's auto-generated source zip. That zip doesn't containvendor/plugin-update-checker(it's bundled bybuild.sh, not committed), so any site that installs it silently stops receiving updates.Fix
REQUIRE_RELEASE_ASSETS, so a release without a matching asset is skipped instead of falling back to the source zip./^everyalt-[0-9][0-9A-Za-z.\-]*\.zip$/), so only the built plugin zip counts as the asset.Same change as Site Manager 1.0.0 (howarddc/site-manager-plugin).
Testing
On a local WordPress 7.1 / PHP 8.5 site, using a zip built from this branch with its version lowered to 1.0.0:
releases/download/v1.1.0/everyalt-1.1.0.zip.wp plugin update everyaltinstalled it, andvendor/plugin-update-checkerwas still present afterwards.php -lpasses and./build.shbuilds.Note on rollout
The fix only protects sites once they're running a version that includes it. The current v1.1.1 draft was built from
mainbefore this change. Either merge this and rebuild and re-attach the 1.1.1 zip (moving thev1.1.1tag), or ship it in 1.1.2.🤖 Generated with Claude Code