test: red-team concurrency & failure-injection conformance tests

[patrickleet]

Summary

Adds red-team / concurrency / failure-injection conformance tests that pin guarantees the recent publish-on-commit + snapshot work introduced but which were previously only covered by unit tests against fakes. All tests exercise existing behavior. They prefer SQLite (run locally without docker) and wire Postgres variants through the existing trampolines (Postgres tests env-gate on DATABASE_URL and skip locally).

No production src/ code was modified. proptest is added as a dev-dependency.

Bugs discovered

None. Every test passes against current code. No test is #[ignore]d.

Tests added (per test)

#	Test	Location	Backends	What it pins
1	racing_commits_one_wins_one_conflicts	persistent_repository_conformance/scenario.rs	hashmap, sqlite, postgres	N tasks load the same aggregate at v0 and commit behind a tokio::sync::Barrier; asserts exactly 1 success, N-1 ConcurrentWrite, and a gap/duplicate-free final stream (sequences [1,2], version 2). Exercises the unique-PK backstop behind the version-check TOCTOU window under real concurrency (existing concurrent_writes_detected races only sequentially).
2	expired_outbox_lease_is_reclaimed_by_second_worker	persistent_repository_conformance/outbox.rs	hashmap, sqlite, postgres	Worker A claims a short lease and never settles (simulated crash); while live, B cannot steal it; after expiry B reclaims (attempts bumped) and completes; A's late complete/release are both fenced (InvalidState). Exercises the SQL claimed_until <= now expiry predicate end-to-end (only the in-memory store proved this before).
3	publish_failure_after_commit_retains_outbox_row_until_delivered	persistent_repository_conformance/outbox.rs	hashmap, sqlite, postgres	Commit aggregate+outbox, then run OutboxDispatcher with a publisher that fails twice then succeeds; row returns to Pending after each failure (attempts 1→2), then Published; bus saw exactly one delivery.
4	read_model_failure_mid_plan_rolls_back_events_and_outbox	sqlite_repository/main.rs + postgres_repository/main.rs	sqlite, postgres	A commit with events + outbox + a two-mutation read-model plan whose second mutation violates a real DB constraint (SQLite BEFORE-INSERT trigger / Postgres CHECK); asserts the event, the outbox row, and the first (already-applied) mutation are all absent (whole-tx rollback).
5	unknown_event_type_in_stream_fails_hydration_with_clear_error (+ a repo-path variant)	upcasting/main.rs	n/a (hashmap)	A stream carrying an unregistered event_name fails hydrate/get with RepositoryError::Replay whose message names the offending event.
6	queued_repo_n_writers_commit_in_fifo_order	queued_repo/main.rs	hashmap (queued)	10 writers contend for one aggregate behind the async lock; asserts final version == N+1 and that the committed event order equals the recorded lock-grant order.
7	replay-determinism proptest (reload_reproduces_in_memory_state, snapshot_hydration_matches_full_replay)	new tests/replay_property/	hashmap	proptest over arbitrary command sequences for a sample Ledger aggregate: reload reproduces in-memory state; snapshot hydration at any frequency equals a full replay (snapshots are a transparent optimization).

How the races/failures are actually created

• cleanup #1, feat: refactor + outbox pattern support #6 use tokio::sync::Barrier + tokio::spawn on a multi-thread runtime to make writers contend, not sleeps.
• event-emitter-rs #2 uses a real short lease + a single sleep just past expiry — lease expiry is inherently wall-clock based and has no barrier/channel substitute through the public store API.
• serialize data #3 drives the real OutboxDispatcher one pass at a time against a flaky AsyncMessagePublisher.
• feat: mutable find by id #4 installs a genuine engine-level constraint (trigger / CHECK) so the second mutation aborts the SQLx transaction mid-plan.
• feat: Repository trait + HashMapRepository #5 commits a raw stream with an unregistered event name and loads it back.

Verification

• cargo fmt --all --check — clean
• cargo build --features sqlite and --features postgres (tests) — compile
• cargo test --features sqlite — all pass; Postgres-backed targets report 0 tests / skip without DATABASE_URL
• Concurrency/timing tests run repeatedly without flakiness

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@patrickleet, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ffc60b83-d3ee-4872-bbfe-6f693efb4f34

📥 Commits

Reviewing files that changed from the base of the PR and between 55c2674 and 7446170.

📒 Files selected for processing (12)

• Cargo.toml
• tests/hashmap_repository_conformance/main.rs
• tests/persistent_repository_conformance/outbox.rs
• tests/persistent_repository_conformance/scenario.rs
• tests/postgres_repository/main.rs
• tests/postgres_repository_conformance/main.rs
• tests/queued_repo/main.rs
• tests/replay_property/aggregate.rs
• tests/replay_property/main.rs
• tests/sqlite_repository/main.rs
• tests/sqlite_repository_conformance/main.rs
• tests/upcasting/main.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hardening/red-team-conformance-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}