Repository navigation
docs(install): keep release getting-started on the published package - #313
Merged
Merged
Conversation
Source-checkout fences in README and INSTALL replace the admitted package. Release qualification refuses that direct origin even when the version matches, so those fences stay for the development-source producer and are not release-install steps. The executed install path is the published index.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
security-audit rejects certifi 2026.7.22 (PYSEC-2026-4320). The Windows getting-started test compared utf-8 fence text with plan()'s platform decode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Published getting-started installs in
README.mdandINSTALL.mdalready use the package index. Later fenced source-checkout commands were still release-install steps. On the retained replay (run 39226326375, docs5a793520, admittedhonua-sdk0.1.16) the unqualifiedgit clonethenpip install ./packages/honua-sdkexited 0 and replaced that package with direct-origin 0.1.17. Later blocks failed the package guard for the same reason. honua-release#718 refuses every direct-origin install, including a version match, so pinning the clone to the admitted version would not qualify it.Those source fences stay in the documents, with the same pip commands, so the development-source producer still captures them. They are marked
doc-run: skipand are not steps in the release install. The commands the getting-started gate executes are publishedpip installcommands. This does not run the executable-docs gate, does not admit a source build, and does not publish a package.gRPC unary/stream and
applyEditsproducers are already on trunk (scripts/_conformance_operations.py, required operations independent of the harness case list, withtests/test_conformance_candidate_operations.pyandtests/test_certification_fragment.py). Local run of those unit tests: 104 passed. No signed-entitlement candidate run was executed here. Trunk conformance run 39402438662 onf36e702stopped in setup withgoverned requirements name another Python producer source; that is not a gRPC or edit result.Testing
python3 -m pytest tests/test_published_getting_started_install.py— 2 passedpython3 scripts/check_docs_command_policy.py— passedruff checkon the touched files — passedpython3 -m pytest tests/test_conformance_candidate_operations.py tests/test_certification_fragment.py tests/test_conformance_entitlement.py— 104 passedRemaining
docs/quickstart.mdis still blocked on honua-release#423 (apply_edits_resultHTTP 400), and the corrected docs are not in a published SDK cohort. Historical source admission under honua-release#721 is unchanged.Refs #257
Refs #282