Repository navigation
fix(utils): cancel late HTTP/2 response bodies - #416
Open
owendavidgoode wants to merge 2 commits into
Open
owendavidgoode wants to merge 2 commits into
owendavidgoode wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/2 response bodies returned after the client closes its stream or session are not cancelled.
Http2ServerResponseexposes the transport lifecycle through its backing stream, so checking the wrapper'sdestroyedproperty misses the already-closed connection.Check the backing HTTP/2 stream before starting the reader pump and cancel the reader when that stream is already closed or destroyed. This covers native and cached responses, including a disconnect during the native response's pre-read tick.
Related to #411 and complementary to #412. The HTTP/2 regression still fails with #412's exact production changes; this patch does not include or replace its HTTP/1 fix.
Validation:
AI assistance was used for implementation and review. All fixtures are synthetic and derived from public source and runtime contracts.