Handle malformed device registry entries#4693
Draft
bgoncal wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4693 +/- ##
=======================================
Coverage ? 44.04%
=======================================
Files ? 282
Lines ? 17149
Branches ? 0
=======================================
Hits ? 7553
Misses ? 9596
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HADataand decode entries lossily.Context
User logs showed device registry updates failing with:
HADataError.incorrectType(key: "identifiers", expected: "Optional<Array<Array<String>>>", actual: "__NSSingleObjectArrayI")Because the registry response was decoded as a typed array, one malformed device blocked persistence for every valid device. This keeps valid devices flowing while still surfacing the malformed entry clearly.