Repository navigation
Load Julia support as a package extension - #53
Merged
Merged
Conversation
gap/Julia.g{d,i} were read only if JuliaInterface and ToolsForHomalg
were marked for loading when CddInterface itself got loaded; loading
them afterwards never provided cdd_PolyhedronByInequalities and
cdd_PolyhedronByGenerators. Declare them in the Extensions component of
PackageInfo.g instead; GAP then reads them as soon as all three packages
are loaded, in any order. Extensions require GAP 4.13, so drop GAP 4.12
from CI.
Assisted-by: Claude Code (Opus 5.5)
1 of 19 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 89.43% 89.43%
=======================================
Files 5 5
Lines 899 899
Branches 30 30
=======================================
Hits 804 804
Misses 91 91
Partials 4 4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now
gap/Julia.g{d,i}(cdd_PolyhedronByInequalities,cdd_PolyhedronByGenerators) were read only if JuliaInterface and ToolsForHomalg were already marked for loading when CddInterface got loaded. JuliaInterface is not the problem: inside Julia it is loaded before every other package. But ToolsForHomalg is not a dependency of CddInterface, so whether the feature is available depended on load order: in GAP running inside Julia,LoadPackage("CddInterface"); LoadPackage("ToolsForHomalg");silently left it out.This PR declares that code in the
Extensionscomponent ofPackageInfo.ginstead (see gap-system/gap#5760 and the section "Extensions Provided by a Package" in the GAP reference manual). GAP reads an extension as soon as all packages it needs are loaded, in whichever order that happens.Extensions require GAP 4.13 (released 2024), so this raises the minimal GAP version to 4.13 and drops 4.12 from CI.
Tested: JuliaInterface is not available on my machine, so I used a stub package providing the few globals ToolsForHomalg needs. With it, the extension is loaded in both load orders and is not loaded without JuliaInterface. The package tests pass.
🤖 Generated with Claude Code