Merge SplitElaborator into Elaborator (close #522)#535
Merged
LPTK merged 3 commits intoJun 29, 2026
Conversation
Contributor
|
Thanks. Could you please add a regression test that shows constructor patterns are now compiled efficiently? |
Member
Author
That's going to be another PR... This PR only moves |
chengluyu
changed the title
SplitElaborator into Elaborator (close #522)
Contributor
|
Please add a short PR description and at least a couple of regression test (including the one in the issue!). |
LPTK
approved these changes
Jun 29, 2026
LPTK
left a comment
LPTK
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I'm not 100% sure what this change buys us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UCS expressions were elaborated in
SplitElaborator. There's no need to maintain a different class which also does elaboration. This PR mergesSplitElaboratorintoElaborator. It's a simple refactor and should be transparent to downstream stages in the compiler.