Remove double lowering#534
Merged
Merged
Conversation
LPTK
requested changes
Jun 25, 2026
LPTK
left a comment
LPTK
left a comment
Contributor
There was a problem hiding this comment.
Very nice! But I have some minor change requests.
AnsonYeung
commented
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
:sjsmore accurate. The old code was using a separate compilation pass which does not use the same IR. Now both:ssjsand:sjsshares the same lowered IR and only differs in the final step.Notable changes from test:
returnare mapped to assignment