[quality] test: cover the fleet-report issue-lifecycle state machine in pkg/dashboard/api_fleet_report.go

[kubestellar-hive]

Test Improvement

Covers the five 0%-covered fleet-report lifecycle functions in src/pkg/dashboard/api_fleet_report.go — SetFleetReportBuildInfo, MarkFleetReportPosted, FleetReportOpenIssue, MarkFleetReportRecovered, ClearFleetReportOpen — all now at 100% (go tool cover -func).

Changes:

• api_fleet_report.go: fleetReportStatePath const → var, plus SetFleetReportStatePathForTest (test-lifetime seam, same convention as knowledge.SetBaseDirForTest at src/pkg/knowledge/api.go:23). Production behavior unchanged.
• New fleet_report_state_test.go pinning:
  • posted → recovered → cleared fingerprint lifecycle round-trip
  • OpenedByHive is never demoted by a re-post with openedByHive=false (gates whether recovery closes the issue)
  • recovery/clear on unknown fingerprints are safe no-ops
  • corrupt state file degrades to empty state and stays writable
  • build-info setter/getter round-trip

Verified: go test ./pkg/dashboard/ passes (99s, full package), go vet clean, new files gofmt-clean.

Deliberately out of scope (noted in the issue): publishFleetReports in cmd/hive (needs a github.Client seam) and AttachFleetReport's persist branch.

Related Issue

Refs #7311 — the cmd/hive publishFleetReports half of the gap is deliberately left open; this PR resolves only the pkg/dashboard state-machine half.

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.78

[kubestellar-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

[clubanderson]

Test-only state machine coverage with a standard test-path seam. LGTM.

[kubestellar-prow]

LGTM label has been added.

Details

Git tree hash: 6803682ae579c3fc2f57589b6c40118467e84d67

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback