Repository navigation
fix(config-health): test via the domain, explain errors, notify - #87
Merged
Merged
Conversation
The panel's notices (default domain, SSH password login, …) were banners above every page. - A bell in the topbar, next to the account icon, lists them; it is shown only while there are notices. - A blinking red dot while some have not been seen; opening the list marks them seen (kept per browser, like dismissals). A notice whose text changes counts as new again. New ones are tagged until it closes. - Each notice can be dismissed from the list, as from the banner; with none left the bell goes away. - The banner component is removed; toasts for toast notices still show. - Strings in all 7 languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… in the bell The check fetched the subscription from the first domain, which can be the server's bare IP: its certificate names the server's hostname, so the fetch failed with an SSL hostname mismatch although nothing was wrong. A domain name is now preferred; with only an IP the server asks itself without the certificate check. Errors get a kind (certificate, timeout, dns, unreachable, http, empty, core) and the dashboard card explains each one and where to look, with the technical message (subscription path removed) on demand and wrapped inside the card. Failed configs get a reason in words. Config health problems also show in the topbar notifications, errors first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 125 | warning | contribute (via Fink 🐦) |
| Identical pattern | 1 | warning | contribute (via Fink 🐦) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Config health on the dashboard could fail with a raw error that overflowed the card:
Could not fetch the subscription: HTTPSConnectionPool(...) SSLError(CertificateError("hostname '<ip>' doesn't match ...")). It didn't say what was wrong or where to look.Root cause: the check fetched the subscription from the first domain, which can be the server's bare IP. The server's certificate is for its name, not that IP, so the fetch failed although the configs were fine.
Change
proxy_v3/config_health.py,config_tester.py):fetch(verify=False)), since no certificate names a bare IP.config_health.py):ConfigHealthCard.vue, newshared/composables/useConfigHealth.ts):usePanelNotifications.ts):Screenshots
With the technical details and a failing app opened:
Tested
verify=Falsefetches it;_host()picks the domain name;total - ok, not from the 60-item list).Review
error_kind,host). Older results still render.🤖 Generated with Claude Code