Repository navigation
fix: end dropped service observers, lower WARP hop MTU, bump sing-box - #155
Merged
Merged
Conversation
daemon.StartedService starts five observer goroutines that only Close ends. The core called CloseService alone, which stops the box but leaves them running, so every start leaked five goroutines: on stop, on a start that failed or was cancelled, and in the CLI instance and the tunnel service. closeService now does both, and every place that drops a service uses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The extra-security WARP hop sends its packets inside the main proxy, which adds its own header. With MTU 1280, behind a shadowsocks server every packet above about 1200 bytes was lost: the tunnel connected and small requests worked, but Chrome's large TLS ClientHello never got through, so no site loaded. 1000 passed every size up to 4 KB on the same path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
veto9292
force-pushed
the
fix/close-started-service
branch
from
October 21, 2026 14:35
0c1fd64 to
1f38ad7
Compare
Contributor
|
minimum mtu for this way is not a good way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code