fix(studio): let only user input hold back font list idle work, and retry after a failure - #4823
Draft
miguel-heygen wants to merge 7 commits into
Draft
miguel-heygen wants to merge 7 commits into
miguel-heygen wants to merge 7 commits into
Conversation
Selecting an element no longer fetches and dedupes the 1.7k-name Google font list, so the response cannot land inside a drag frame. The lists are fetched once per session on the first open.
…hen input is idle
…etry after a failure
miguel-heygen
force-pushed
the
perf/studio-font-list-on-demand
branch
from
October 1, 2026 15:06
7ccf56d to
c53de72
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4794. Retarget to main once that merges.
What
Three follow-ups to the idle font-list processing:
INPUT_EVENTS; the loop's wake sources are those plus scroll, resize and visibility). The input listeners attach with the first overlay subscriber, so input that happens before the lists arrive still counts.Tests
overlayFrameLoop.test.ts:propertyPanelFont.test.tsx:All three fail with the two source files at #4794's head. With the re-check at the idle callback removed, the first one fails.