fix(studio): undo that reloads the preview keeps the timeline clips on screen - #4790
Draft
miguel-heygen wants to merge 2 commits into
Draft
miguel-heygen wants to merge 2 commits into
miguel-heygen wants to merge 2 commits into
Conversation
miguel-heygen
force-pushed
the
fix/studio-undo-keeps-timeline-clips
branch
from
September 30, 2026 23:43
2a98129 to
0aa8b2b
Compare
Edit accuracy: 434 passing here, 434 on the base branchThe gate passes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Undo or redo of an edit inside a nested composition (and any other undo that reloads the preview) no longer blanks the timeline. Before, the timeline dropped to its empty "Drop media here" state and the player controls greyed out until the reloaded preview reported its clips.
Why
When an undo could not be applied in place, the undo path emptied the timeline store and marked it not ready before reloading the preview, and waited for the reload to fill it again. No other reload does that: a commit that reloads the preview keeps the clips on screen until the reloaded preview reports its own. The preview often reloads a nested composition in place now (a scene swap), so the store sat empty for the whole swap.
Repro: a root composition with a GSAP sub-composition. Move an element of the sub-composition, then undo. The timeline blanks, then comes back.
Related work
Found while verifying the undo stack (#4771 to #4783); main has it too.
How
Test plan
Before
Right after undoing a nested move, the timeline shows the empty-project state.
before-undo.webm
After
The same undo: the timeline keeps its clips throughout.
after-undo.webm