Return response headers from request_to_file in httpc adapter#175
Merged
Return response headers from request_to_file in httpc adapter#175
Conversation
The httpc {stream, Filename} option discards response headers and
status code, returning only {ok, saved_to_file} for 2xx responses.
This meant callers never received headers like etag, breaking
conditional download support.
Use async streaming ({stream, self}) instead, which delivers headers
in stream_start while still streaming body chunks to disk without
loading the full response into memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The httpc {stream, Filename} option discards response headers and status code, returning only {ok, saved_to_file} for 2xx responses. This meant callers never received headers like etag, breaking conditional download support.
Use async streaming ({stream, self}) instead, which delivers headers in stream_start while still streaming body chunks to disk without loading the full response into memory.