Skip to content

Replace httpc with vendored Mint HTTP/1+HTTP/2 client #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ericmj wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Replace httpc with vendored Mint HTTP/1+HTTP/2 client #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d853bf9
Vendor mint and hpax
ericmj Apr 11, 2026
54c57b3
Add hex_core HTTP adapter backed by vendored Mint
claude Apr 12, 2026
4336ca6
Unify HTTP/1 and HTTP/2 pool, fix 1xx handling
ericmj Apr 12, 2026
312020b
Stream request bodies, fix IPv4/IPv6 fallback, document Mint PRs
ericmj Apr 12, 2026
63716ab
Add real HTTPS integration tests against hex.pm and repo.hex.pm
ericmj Apr 12, 2026
6a1a3fa
Cover proxy routing, IPv4/IPv6 pool separation, Conn crash recovery
ericmj Apr 12, 2026
ae845da
Default to HTTP/1 only — faster than HTTP/2 for hex's workload
ericmj Apr 12, 2026
09ea172
Patch Mint to tune HTTP/2 connection-level window
ericmj Apr 12, 2026
1d8612e
Negotiate HTTP/2 by default
ericmj Apr 12, 2026
7fcea16
Re-vendor Mint with set_window_size/3, call it from Conn
ericmj Apr 12, 2026
f470149
Re-vendor Mint with larger default HTTP/2 receive windows
ericmj Apr 13, 2026
98805e3
Stream response bodies to disk in request_to_file/6
ericmj Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .formatter.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
[
inputs: [
"*.exs",
"config/*.exs",
"lib/**/*.ex",
"test/**/*.{ex,exs}"
]
inputs:
["*.exs", "config/*.exs", "test/**/*.{ex,exs}"] ++
(Path.wildcard("lib/**/*.ex") -- Path.wildcard("lib/hex/mint/**/*.ex"))
]
16 changes: 2 additions & 14 deletions lib/hex/application.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ defmodule Hex.Application do
Mix.SCM.append(Hex.SCM)
Mix.RemoteConverger.register(Hex.RemoteConverger)

start_httpc()

opts = [strategy: :one_for_one, name: Hex.Supervisor]
Supervisor.start_link(children(), opts)
end
Expand All @@ -33,25 +31,14 @@ defmodule Hex.Application do
defp dev_setup, do: :ok
end

defp start_httpc() do
:inets.start(:httpc, profile: :hex)

opts = [
max_sessions: 8,
max_keep_alive_length: 4,
keep_alive_timeout: 120_000
]

:httpc.set_options(opts, :hex)
end

if Mix.env() == :test do
defp children do
[
Hex.Netrc.Cache,
Hex.OAuth,
Hex.Repo,
Hex.State,
Hex.HTTP.Pool,
Hex.Server,
{Hex.Parallel, [:hex_fetcher]}
]
Expand All @@ -63,6 +50,7 @@ defmodule Hex.Application do
Hex.OAuth,
Hex.Repo,
Hex.State,
Hex.HTTP.Pool,
Hex.Server,
{Hex.Parallel, [:hex_fetcher]},
Hex.Registry.Server,
Expand Down
Loading
Loading