Repository navigation
feat: allow disabling dm-crypt workqueues for encrypted volumes - #1563
Open
lukasmetzner wants to merge 2 commits into
Open
lukasmetzner wants to merge 2 commits into
lukasmetzner wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
+ Coverage 82.17% 83.25% +1.07%
==========================================
Files 16 16
Lines 1470 1505 +35
==========================================
+ Hits 1208 1253 +45
+ Misses 262 252 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukasmetzner
force-pushed
the
feat/luks-disable-workqueues
branch
from
November 16, 2026 07:54
d37192d to
a54649b
Compare
Member
Author
Benchmark resultsfio was used as a benchmarking tool. fio config used for testing.Each run (fast and slow) used its own new Hetzner Cloud volume (6 volumes total). Parallel runs (fast/slow) were scheduled with preferred pod anti-affinity on Ranges overlap means the ranges share values, so some slow runs beat some fast runs.
Summary
Raw fio output: results-fast-1.txt |
lukasmetzner
force-pushed
the
feat/luks-disable-workqueues
branch
3 times, most recently
from
November 16, 2026 13:18
f72df2b to
bb8d7f7
Compare
Add the optional encryption secret keys encryption-disable-read-workqueue and encryption-disable-write-workqueue. When set, the corresponding --perf-no_read_workqueue and --perf-no_write_workqueue flags are passed to luksOpen, reducing I/O latency on encrypted volumes. Requires Linux 5.9+. Enable both keys in the encrypted kubernetes e2e run. Closes #1535
lukasmetzner
force-pushed
the
feat/luks-disable-workqueues
branch
from
November 16, 2026 13:19
bb8d7f7 to
d994684
Compare
lukasmetzner
force-pushed
the
feat/luks-disable-workqueues
branch
from
November 16, 2026 13:24
d994684 to
4a6cdf2
Compare
lukasmetzner
marked this pull request as ready for review
November 18, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the optional encryption secret keys
encryption-disable-read-workqueueandencryption-disable-write-workqueue. When set, the corresponding--perf-no_read_workqueueand--perf-no_write_workqueueflags are passed to luksOpen, reducing I/O latency on encrypted volumes. Requires Linux 5.9+.When work queues are disabled, the tail latency is significantly better. CPU usage moves from kernel threads into the pod's own cgroups, but the overall usage does not change. Users have to account for this when using tight Kubernetes CPU limits. Benchmarks: #1563 (comment)
Enable both keys in the encrypted kubernetes e2e run.
Closes #1535