Support virtio entropy device

[sbutz]

In virtualized deployments seed DRNG from entropy provided by host.

Tbh this driver is of limited use, but was good exercise to get started with virtio.

Arch	mmio	pci
x86_64	✅	✅
aarch64	✅	✅
riscv64	✅	❌ - pci will be added with #2550

Blocked by integration of rust-osdev/virtio-spec-rs#24 and new release of virtio-spec-rs.

[github-actions]

Benchmark Results

Details

Benchmark	Current: a64e03a	Previous: 2e23902	Performance Ratio
startup_benchmark Build Time	83.06 s	80.34 s	1.03 ❗
startup_benchmark File Size	0.77 MB	0.80 MB	0.96 ❗
Startup Time - 1 core	0.74 s (±0.02 s)	0.75 s (±0.02 s)	0.99
Startup Time - 2 cores	0.75 s (±0.02 s)	0.74 s (±0.02 s)	1.02
Startup Time - 4 cores	0.76 s (±0.02 s)	0.74 s (±0.02 s)	1.02
multithreaded_benchmark Build Time	84.12 s	82.11 s	1.02 ❗
multithreaded_benchmark File Size	0.87 MB	0.86 MB	1.02 ❗
Multithreaded Pi Efficiency - 2 Threads	88.20 % (±4.96 %)	85.89 % (±6.61 %)	1.03
Multithreaded Pi Efficiency - 4 Threads	43.74 % (±1.63 %)	43.43 % (±2.56 %)	1.01
Multithreaded Pi Efficiency - 8 Threads	25.43 % (±1.25 %)	25.76 % (±1.53 %)	0.99
micro_benchmarks Build Time	85.15 s	80.40 s	1.06 ❗
micro_benchmarks File Size	0.88 MB	0.86 MB	1.02 ❗
Scheduling time - 1 thread	67.14 ticks (±4.78 ticks)	62.65 ticks (±4.06 ticks)	1.07
Scheduling time - 2 threads	36.25 ticks (±5.76 ticks)	34.08 ticks (±4.10 ticks)	1.06
Micro - Time for syscall (getpid)	4.47 ticks (±0.72 ticks)	3.45 ticks (±0.58 ticks)	1.29 ❗
Memcpy speed - (built_in) block size 4096	85186.47 MByte/s (±58793.02 MByte/s)	82448.38 MByte/s (±56997.13 MByte/s)	1.03
Memcpy speed - (built_in) block size 1048576	30362.29 MByte/s (±24551.43 MByte/s)	30585.98 MByte/s (±24707.84 MByte/s)	0.99
Memcpy speed - (built_in) block size 16777216	26208.24 MByte/s (±21614.43 MByte/s)	26340.06 MByte/s (±21720.96 MByte/s)	0.99
Memset speed - (built_in) block size 4096	85186.73 MByte/s (±58793.16 MByte/s)	82292.76 MByte/s (±56891.50 MByte/s)	1.04
Memset speed - (built_in) block size 1048576	31090.20 MByte/s (±24984.62 MByte/s)	31323.85 MByte/s (±25145.86 MByte/s)	0.99
Memset speed - (built_in) block size 16777216	26982.12 MByte/s (±22111.51 MByte/s)	27104.68 MByte/s (±22209.94 MByte/s)	1.00
Memcpy speed - (rust) block size 4096	75432.06 MByte/s (±52504.08 MByte/s)	74097.96 MByte/s (±51811.44 MByte/s)	1.02
Memcpy speed - (rust) block size 1048576	30379.48 MByte/s (±24586.35 MByte/s)	30361.60 MByte/s (±24602.37 MByte/s)	1.00
Memcpy speed - (rust) block size 16777216	26749.34 MByte/s (±22107.83 MByte/s)	27625.34 MByte/s (±22806.88 MByte/s)	0.97
Memset speed - (rust) block size 4096	75832.43 MByte/s (±52794.00 MByte/s)	74373.47 MByte/s (±51976.48 MByte/s)	1.02
Memset speed - (rust) block size 1048576	31126.82 MByte/s (±25022.79 MByte/s)	31110.89 MByte/s (±25033.24 MByte/s)	1.00
Memset speed - (rust) block size 16777216	27517.55 MByte/s (±22591.93 MByte/s)	28386.93 MByte/s (±23265.03 MByte/s)	0.97
alloc_benchmarks Build Time	76.78 s	74.76 s	1.03 ❗
alloc_benchmarks File Size	0.84 MB	0.87 MB	0.97 ❗
Allocations - Allocation success	91.34 %	91.31 %	1.00 ❗
Allocations - Deallocation success	100.00 %	100.00 %	1
Allocations - Pre-fail Allocations	61.54 %	61.44 %	1.00 ❗
Allocations - Average Allocation time	2530.69 Ticks (±763.42 Ticks)	5860.58 Ticks (±98.43 Ticks)	0.43 ❗
Allocations - Average Allocation time (no fail)	3571.42 Ticks (±667.76 Ticks)	6554.81 Ticks (±92.86 Ticks)	0.54 ❗
Allocations - Average Deallocation time	691.40 Ticks (±141.02 Ticks)	1805.01 Ticks (±250.35 Ticks)	0.38 ❗
mutex_benchmark Build Time	80.80 s	79.82 s	1.01 ❗
mutex_benchmark File Size	0.88 MB	0.86 MB	1.02 ❗
Mutex Stress Test Average Time per Iteration - 1 Threads	12.04 ns (±0.28 ns)	12.10 ns (±0.41 ns)	1.00
Mutex Stress Test Average Time per Iteration - 2 Threads	41.44 ns (±2.40 ns)	40.26 ns (±1.68 ns)	1.03

This comment was automatically generated by workflow using github-action-benchmark.

[sbutz]

@mkroening does the new feature virtio-entropy require a new kernel version and a bump in hermit-rs?
The ci tests are added in the last commit. It can be moved to separate PR which can be merged after the next new kernel release and bump in hermit-rs.

[mkroening]

@mkroening does the new feature virtio-entropy require a new kernel version and a bump in hermit-rs? The ci tests are added in the last commit. It can be moved to separate PR which can be merged after the next new kernel release and bump in hermit-rs.

All it should need is the new feature being listed in the hermit-rs wrapper crate's Cargo.toml. A new kernel release or kernel bump in hermit-rs should not be necessary for the kernel CI to pick up the feature. Kernel CI always uses the latest hermit-rs commit. So please open a PR in hermit-rs, adding the feature. That uncontroversial one-line change can be merged immediately to unblock your further work here.

Sorry for the long wait. I have not forgotten this PR and will review it in the next days. :)

Edit: Thanks for keeping this PR up to date and rebasing on #2527, which I had prioritized for review in preparation for this PR.

[sbutz]

Adding feature flag in hermit-rs: hermit-os/hermit-rs#1049