Repository navigation
Make Date header parsing locale-independent - #1667
Merged
diachenko-mischa merged 2 commits intoFeb 25, 2026
Merged
diachenko-mischa merged 2 commits into
diachenko-mischa merged 2 commits into
Conversation
diachenko-mischa
force-pushed
the
mdiachenko/HERESUP-57013-LocaleIndependantDateParsingBoost
branch
from
February 23, 2026 18:18
4aadfd6 to
4863a44
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 80.33% 80.37% +0.04%
==========================================
Files 350 351 +1
Lines 14052 14186 +134
Branches 1517 1543 +26
==========================================
+ Hits 11288 11401 +113
- Misses 2147 2156 +9
- Partials 617 629 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use boost::date_time to ensure cross platform compatibility. Supersedes the b877dc4 Relates-To: HERESUP-57013 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
diachenko-mischa
force-pushed
the
mdiachenko/HERESUP-57013-LocaleIndependantDateParsingBoost
branch
from
February 24, 2026 06:26
6c7ec07 to
a279c11
Compare
rustam-gamidov-here
requested review from
andrey-kashcheev,
asopov-here,
khomenkd and
mykolamalik
February 24, 2026 08:19
andrey-kashcheev
previously approved these changes
Feb 24, 2026
| @@ -0,0 +1,322 @@ | |||
| /* | |||
| * Copyright (C) 2020-2024 HERE Europe B.V. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2020-2024 HERE Europe B.V. | |
| * Copyright (C) 2026 HERE Europe B.V. |
| @@ -0,0 +1,38 @@ | |||
| /* | |||
| * Copyright (C) 2020-2026 HERE Europe B.V. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2020-2026 HERE Europe B.V. | |
| * Copyright (C) 2026 HERE Europe B.V. |
| @@ -0,0 +1,117 @@ | |||
| /* | |||
| * Copyright (C) 2020-2024 HERE Europe B.V. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2020-2024 HERE Europe B.V. | |
| * Copyright (C) 2026 HERE Europe B.V. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2020-2026 HERE Europe B.V. |
rustam-gamidov-here
previously approved these changes
Feb 24, 2026
diachenko-mischa
dismissed stale reviews from rustam-gamidov-here and andrey-kashcheev
via
February 24, 2026 17:02
e29ba09
- increased coverage - updated copyright headers - add leap seconds boundary Relates-To: HERESUP-57013 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
diachenko-mischa
force-pushed
the
mdiachenko/HERESUP-57013-LocaleIndependantDateParsingBoost
branch
from
February 24, 2026 17:03
e29ba09 to
5b516cb
Compare
rustam-gamidov-here
approved these changes
Feb 25, 2026
andrey-kashcheev
approved these changes
Feb 25, 2026
diachenko-mischa
deleted the
mdiachenko/HERESUP-57013-LocaleIndependantDateParsingBoost
branch
February 25, 2026 14:57
asopov-here
pushed a commit
that referenced
this pull request
Feb 27, 2026
* Make Date header parsing locale-independent Use boost::date_time to ensure cross platform compatibility. Supersedes the b877dc4 Relates-To: HERESUP-57013 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com> * Fix Review comments - increased coverage - updated copyright headers - add leap seconds boundary Relates-To: HERESUP-57013 Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com> --------- Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use boost::date_time to ensure cross platform compatibility.
Supersedes the b877dc4
Relates-To: HERESUP-57013