gh-423: Factorize jackknife_cls for parallelism#424
Open
ucapbba wants to merge 7 commits into
Open
Conversation
…todo, clean workbook and remove dunmplicate code
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #423
The jackknife_cls method has been factorized into individual methods _compute_single_jk_alm _compute_single_jk_cls. For now the old jackknife_cls has been renamed to jackknife_cls_old should any additional comparison be required.
I have tested both methods are the same by comparing the cls for delete 12 and delete 2 (notebook available on demand). I have also implemented the individual methods in a fully parallel setup, giving significant performance improvement.