Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #413 by making heracles.mapping.transform() impose (write) the expected spin into a map’s dtype metadata when it is missing, enabling callers to pass in their own maps without pre-populating metadata.
Changes:
- Update
transform()to fill missingspinmetadata from the correspondingField.spin, and raise a clearValueErroron spin mismatch. - Add/adjust tests to cover: normal transform behavior, filling missing spin metadata, and mismatch error behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
heracles/mapping.py |
Ensures transform() enforces/repairs spin metadata consistency before calling the mapper transform. |
tests/test_mapping.py |
Adds targeted test coverage for missing-spin fill and mismatch error handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #413
This should allow people to use our methods with their own maps without having to worry about metadata.