Skip to content

fix: update markdown-it to restore report publishing - #86

Merged
HemSoft merged 1 commit into
mainfrom
fix/markdown-it-audit
Oct 29, 2026
Merged

HemSoft merged 1 commit into
mainfrom
fix/markdown-it-audit

Conversation

@HemSoft

@HemSoft HemSoft commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

The scheduled Pages publication stopped at validation because the markdown-it 14.3.1 override is vulnerable to GHSA-r7fv-28h4-cvq7, GHSA-vfgh-jcmw-g37q, and GHSA-gfr2-rv44-r23c. Pin the patched 14.3.3 release and update its lockfile integrity so publication can pass security validation again.

Validation

  • Reproduced the original npm audit failure locally.
  • Clean npm ci and npm audit --audit-level=low now pass with zero vulnerabilities.
  • Full local validation passed under Python 3.12.15 and Node 24.22.1: unit tests, coverage/risk, mutation qualification, Python/Markdown lint, actionlint 1.7.12, source/secret checks, security tests, pip-audit, npm audit, browser suite, performance budget tests, budget failure probe, full benchmark, and benchmark summary. CI also validates the supported Node 22 runtime and Windows unit tests.
  • A second full browser run under Node 22.22.2 passed all 64 tests. The first CI run timed out in the existing editor accessibility test; its focused local recheck passed in 16.8 seconds. Failed CI jobs are rerunning on the unchanged SFL PASS head.
  • Weekly Monday publication matches README.md. No schedule change.

@HemSoft HemSoft added the model:gpt-6.1-sol PR authored by gpt-6.1-sol label Oct 29, 2026
@HemSoft

HemSoft commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

@sfl review

@hemsoft-sfl-reviewer hemsoft-sfl-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verdict: PASS • Round 1

Review done by claude-opus-5-5 (adversarial to codex)

The PR moves the markdown-it override from 14.3.1 to 14.3.3 and updates the single nested lockfile entry to match. No defect was found: 14.3.3 is the first patched version for all three cited GHSAs, it is within markdownlint-cli's ~14.3.0 range, and the lockfile agrees with package.json.

🔨 Full-Spectrum Review Summary

Effort: high
Review time: 0m 52s
Token count: Unavailable

Pass 🔴 Critical 🟠 High 🟡 Medium ⚪ Low
🔒 Security 0 0 0 0
✅ Accuracy 0 0 0 0
🧰 Quality & Maintainability 0 0 0 0
Total 0 0 0 0

Key Findings

No material defects found.

Coverage

  • Files reviewed:
    • package.json
    • package-lock.json
  • Context read:
    • .github/workflows/validate.yml
    • .github/workflows/pages.yml
    • .github/dependabot.yml
    • PR #86 title and body
    • GitHub advisories GHSA-r7fv-28h4-cvq7, GHSA-vfgh-jcmw-g37q, GHSA-gfr2-rv44-r23c
    • Check runs for head `beacc919`
  • Verified:
    • Compare base_commit.sha is 946c2085ff4071fa2e3721932c2b91191b693821, the last commit is beacc919a0b82b547f095d1cec5bfe865972ffe9, the range is 1 ahead and 0 behind, and PR head and base match
    • The diff touches only package.json (the override) and package-lock.json (version, resolved and integrity of node_modules/markdownlint-cli/node_modules/markdown-it)
    • The head lockfile has exactly one markdown-it package entry, so no other copy stays on 14.3.1
    • markdownlint-cli 0.49.1 requires markdown-it ~14.3.0, and 14.3.3 is within that range
    • GitHub advisory API lists 14.3.3 as first patched for GHSA-vfgh and GHSA-gfr2, and 14.3.2 for GHSA-r7fv
    • The nested deps of 14.3.3 (entities, linkify-it, uc.micro, argparse, mdurl, punycode.js) all have resolvable entries in the lockfile
    • validate.yml runs npm ci and npm audit --audit-level=low, and pages.yml reuses validate.yml on the Monday cron, which matches the PR's stated publishing path
    • The head check run Dependency and source security (npm ci plus npm audit) concluded success, observed through the GitHub API
  • Not verified:
    • The npm registry tarball and the sha512 integrity for 14.3.3 were not checked directly because only GitHub API calls are allowed; the successful CI npm ci is indirect evidence
    • Upstream behavior changes between markdown-it 14.3.1 and 14.3.3 that could affect markdownlint results were not checked
    • The Lint and browser smoke and Mutation qualification check runs were still in progress at review time
    • The PR body's local validation claims (npm audit reproduced, full validation in progress) are the author's statements and were not verified
  • Tests run: None. Reviewer execution is disabled.

HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head beacc919a0b82b547f095d1cec5bfe865972ffe9 • SFL v0

@HemSoft

HemSoft commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

Full local validation passed, including all 64 browser tests. The CI browser job timed out after 30 seconds in the existing desktop/mobile editor accessibility test. A focused local recheck passed in 16.8 seconds. Re-running failed CI jobs on the unchanged SFL-reviewed head.

@HemSoft
HemSoft merged commit 2153f1b into main Oct 29, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:gpt-6.1-sol PR authored by gpt-6.1-sol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant