Skip to content

fix(test): serialize tests that mutate CORTEX_MAX_TOPOLOGY_BYTES #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammar-s847 merged 1 commit into from
May 26, 2026
Merged

fix(test): serialize tests that mutate CORTEX_MAX_TOPOLOGY_BYTES #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/disk/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,16 @@ mod tests {
event::{CortexEventKind, CortexEventRecord},
topology::{NeuronSpec, SynapseSpec, TopologyDefaults},
};
use std::sync::Mutex;
use std::time::SystemTime;

// Serializes any test that reads `CORTEX_MAX_TOPOLOGY_BYTES`, since
// `topology_size_limit_enforced` mutates it as process-global state
// and `cargo test` runs tests in parallel by default. Without this,
// a round-trip test can observe the 16-byte limit set by the
// size-limit test and erroneously fail with `TopologyTooLarge`.
static TOPOLOGY_LIMIT_ENV: Mutex<()> = Mutex::new(());

fn tmp_root(label: &str) -> PathBuf {
let nanos = SystemTime::now()
.duration_since(SystemTime::UNIX_EPOCH)
Expand Down Expand Up @@ -389,6 +397,8 @@ mod tests {

#[test]
fn topology_round_trips_on_disk() {
// Lock against `topology_size_limit_enforced`; see TOPOLOGY_LIMIT_ENV.
let _guard = TOPOLOGY_LIMIT_ENV.lock().unwrap_or_else(|e| e.into_inner());
let root = tmp_root("topology");
let t = hh_empty();
write_topology(&root, &t).unwrap();
Expand All @@ -399,6 +409,8 @@ mod tests {

#[test]
fn topology_size_limit_enforced() {
// Holds for the duration of the env-var mutation. See TOPOLOGY_LIMIT_ENV.
let _guard = TOPOLOGY_LIMIT_ENV.lock().unwrap_or_else(|e| e.into_inner());
let root = tmp_root("limit");
let t = hh_empty();
write_topology(&root, &t).unwrap();
Expand Down
Loading