Repository navigation
fix(session): ignore non-object JSON records - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
A file can parse as JSON without being a session record. Check that the top level is an object before either the catalog or the resume path reads its fields. Valid objects and the storage format are unchanged. Nothing is removed from disk.
Five new cases fail on the 0.14.0 source and pass with the guard. The complete local suite is 373 passed, with the live smoke test skipped. Ruff passes. I also built the wheel and installed it in an empty environment:
--list-sessionsstill displays the valid entry beside[], and the installed session loader returnsNonefor the invalid record. No provider was contacted. This PR does not publish a new wheel to PyPI.