Skip to content

H-6450: Reduce space around entity headers#8707

Open
CiaranMn wants to merge 1 commit into
mainfrom
cm/reduce-padding-on-entity-headers
Open

H-6450: Reduce space around entity headers#8707
CiaranMn wants to merge 1 commit into
mainfrom
cm/reduce-padding-on-entity-headers

Conversation

@CiaranMn
Copy link
Copy Markdown
Member

@CiaranMn CiaranMn commented May 7, 2026

🌟 What is the purpose of this PR?

There's a lot of white space around the header on both the entities page and on individual entity views.

I don't know how long this has been here but it takes up a lot of screen real estate at the expense of meaningful content.

This PR reduces it (see difference below).

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

📹 Demo

Previous

Screenshot 2026-05-07 at 18 35 23 Screenshot 2026-05-07 at 18 35 30

Now

Screenshot 2026-05-07 at 18 31 16 Screenshot 2026-05-07 at 18 31 39

@CiaranMn CiaranMn requested a review from vilkinsons May 7, 2026 16:40
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 25, 2026 5:04pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview May 25, 2026 5:04pm
petrinaut Skipped Skipped May 25, 2026 5:04pm

@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Low Risk
Pure layout/spacing tweaks in two presentational components with no logic, routing, or data changes.

Overview
Tightens vertical spacing around entity list and single-entity headers so more content fits above the fold.

On entities.page.tsx, the list header Typography (h1) no longer uses my={3}—vertical margin on the title comes only from the parent Stack’s my={3}. On entity-header.tsx, the tab strip wrapper drops from mt={7.5} to mt={3}, bringing EntityEditorTabs closer to the entity title.

Reviewed by Cursor Bugbot for commit d1c013c. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > frontend Owned by the @frontend team area/apps labels May 7, 2026
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 7, 2026

🤖 Augment PR Summary

Summary: Reduces excessive whitespace around entity page headers to reclaim vertical screen space.

Changes:

  • Removed extra vertical margin from the entities page h1 title.
  • Reduced top margin before entity editor tabs within the entity header component.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown
Member

@vilkinsons vilkinsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breadcrumbs to be moved up into slideover top-bar (per in-person convo).

@CiaranMn CiaranMn force-pushed the cm/reduce-padding-on-entity-headers branch from 729772d to d1c013c Compare May 25, 2026 16:57
@vercel vercel Bot temporarily deployed to Preview – petrinaut May 25, 2026 16:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants