Skip to content

BE-524: HashQL: Remove island schedule module#8694

Open
indietyp wants to merge 1 commit into
bm/be-525-hashql-remove-implicit-type-widening-into-num-for-intfrom
bm/be-524-hashql-remove-island-dag
Open

BE-524: HashQL: Remove island schedule module#8694
indietyp wants to merge 1 commit into
bm/be-525-hashql-remove-implicit-type-widening-into-num-for-intfrom
bm/be-524-hashql-remove-island-dag

Conversation

@indietyp
Copy link
Copy Markdown
Member

@indietyp indietyp commented May 4, 2026

🌟 What is the purpose of this PR?

The island::schedule module, which provided topological scheduling with parallelism level assignment for execution islands, has been removed. This includes the IslandSchedule and ScheduledIsland types, the schedule and schedule_in methods on IslandGraph, and all associated tests. The scheduling functionality is no longer needed or has been superseded by an alternative approach.

🔍 What does this change?

  • Removes the schedule submodule from island/mod.rs
  • Deletes island/schedule/mod.rs, which contained the IslandSchedule and ScheduledIsland types along with the Kahn's algorithm-based topological level assignment implementation
  • Deletes island/schedule/tests.rs, which contained tests for level ordering, contiguity, and full node coverage of the schedule
  • Removes the public re-exports of IslandSchedule and ScheduledIsland from pass/execution/mod.rs

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🛡 What tests cover this?

The tests that previously covered the scheduling logic have been removed alongside the implementation.

❓ How to test this?

  1. Checkout the branch
  2. Run cargo test in libs/@local/hashql/mir
  3. Confirm that the build succeeds and no references to IslandSchedule or ScheduledIsland remain

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment May 25, 2026 2:09pm
petrinaut Ready Ready Preview May 25, 2026 2:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview May 25, 2026 2:09pm

@vercel vercel Bot temporarily deployed to Preview – petrinaut May 4, 2026 10:40 Inactive
@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

Low Risk
Dead-code removal with no remaining references; execution analysis still builds IslandGraph the same way.

Overview
Removes the island scheduling layer from HashQL MIR execution: the island::schedule submodule and its public exports (IslandSchedule, ScheduledIsland) are deleted entirely.

That module implemented Kahn-style topological ordering of IslandGraph nodes with parallelism levels (same-level islands were treated as independent). IslandGraph::schedule / schedule_in and the dedicated schedule tests go with it. Island placement and IslandGraph construction in ExecutionAnalysis are unchanged; only the optional schedule-on-graph API is gone.

Reviewed by Cursor Bugbot for commit 5aa1fb4. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels May 4, 2026
Copy link
Copy Markdown
Member Author

indietyp commented May 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 4, 2026

🤖 Augment PR Summary

Summary: Removes the deprecated/unused HashQL MIR island scheduling implementation and its public surface area.

Changes:

  • Drops the pass::execution::island::schedule submodule from island/mod.rs
  • Deletes the scheduling implementation (IslandGraph::schedule/schedule_in) and the related types (IslandSchedule, ScheduledIsland)
  • Removes the schedule unit tests that validated ordering/level semantics
  • Removes the re-exports of IslandSchedule/ScheduledIsland from pass::execution

Technical Notes: This PR is primarily an API/code deletion; downstream code must no longer rely on the removed scheduling helpers and should use the newer/superseding execution approach instead.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 4, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 56 skipped benchmarks1


Comparing bm/be-524-hashql-remove-island-dag (5aa1fb4) with bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int (7e018f0)

Open in CodSpeed

Footnotes

  1. 56 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from 07de63c to b87ca3d Compare May 4, 2026 11:34
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 94f20af to 94254d8 Compare May 13, 2026 09:57
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from 8e7b7a8 to 80c753b Compare May 13, 2026 09:57
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from 80c753b to bb9d9da Compare May 15, 2026 07:49
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 94254d8 to 78f76e2 Compare May 15, 2026 07:49
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from bb9d9da to 07bb2cf Compare May 19, 2026 15:43
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 78f76e2 to 11715f8 Compare May 19, 2026 15:43
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 11715f8 to bb97a73 Compare May 20, 2026 14:46
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from 45358ac to f13bd33 Compare May 22, 2026 11:21
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from bb97a73 to 7c2c99f Compare May 22, 2026 11:21
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 7c2c99f to fed3275 Compare May 25, 2026 13:27
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from f13bd33 to 6c7c09d Compare May 25, 2026 13:27
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from fed3275 to 2ffc3ed Compare May 25, 2026 13:58
@indietyp indietyp force-pushed the bm/be-525-hashql-remove-implicit-type-widening-into-num-for-int branch from bec8970 to 7e018f0 Compare May 25, 2026 14:00
@indietyp indietyp force-pushed the bm/be-524-hashql-remove-island-dag branch from 2ffc3ed to 5aa1fb4 Compare May 25, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

1 participant