BE-524: HashQL: Remove island schedule module#8694
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryLow Risk Overview That module implemented Kahn-style topological ordering of Reviewed by Cursor Bugbot for commit 5aa1fb4. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Augment PR SummarySummary: Removes the deprecated/unused HashQL MIR island scheduling implementation and its public surface area. Changes:
Technical Notes: This PR is primarily an API/code deletion; downstream code must no longer rely on the removed scheduling helpers and should use the newer/superseding execution approach instead. 🤖 Was this summary useful? React with 👍 or 👎 |
Merging this PR will not alter performance
Comparing Footnotes
|
07de63c to
b87ca3d
Compare
94f20af to
94254d8
Compare
8e7b7a8 to
80c753b
Compare
80c753b to
bb9d9da
Compare
94254d8 to
78f76e2
Compare
bb9d9da to
07bb2cf
Compare
78f76e2 to
11715f8
Compare
11715f8 to
bb97a73
Compare
45358ac to
f13bd33
Compare
bb97a73 to
7c2c99f
Compare
7c2c99f to
fed3275
Compare
f13bd33 to
6c7c09d
Compare
fed3275 to
2ffc3ed
Compare
bec8970 to
7e018f0
Compare
2ffc3ed to
5aa1fb4
Compare

🌟 What is the purpose of this PR?
The
island::schedulemodule, which provided topological scheduling with parallelism level assignment for execution islands, has been removed. This includes theIslandScheduleandScheduledIslandtypes, thescheduleandschedule_inmethods onIslandGraph, and all associated tests. The scheduling functionality is no longer needed or has been superseded by an alternative approach.🔍 What does this change?
schedulesubmodule fromisland/mod.rsisland/schedule/mod.rs, which contained theIslandScheduleandScheduledIslandtypes along with the Kahn's algorithm-based topological level assignment implementationisland/schedule/tests.rs, which contained tests for level ordering, contiguity, and full node coverage of the scheduleIslandScheduleandScheduledIslandfrompass/execution/mod.rsPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
The tests that previously covered the scheduling logic have been removed alongside the implementation.
❓ How to test this?
cargo testinlibs/@local/hashql/mirIslandScheduleorScheduledIslandremain