Repository navigation
refactor(oidc): remove name search param from provider list query - #5
Merged
Merged
Conversation
…sword - Add LoginType.INSTALL_ID constant - Add AuthInstallIdService to verify credentials against system install_id and find-or-create admin user - Wire INSTALL_ID case into AuthService login switch - Import UpdateCheckModule in AuthModule for getInstallId() - Add generateInstallIdToken in AuthTokenService and skip DB session check for install_id tokens - Update CI workflows to use DATABK_TOKEN for ghcr.io push
RbacAuditService now requires UpdateCheckService as a constructor dependency. Update test instantiations in audit.service.spec.ts and rbac-authorization.service.spec.ts to provide a mocked UpdateCheckService with getInstallId, fixing TS2554 type check errors.
install_id login does not persist a user row, so RbacAuthorizationService threw 'Account does not exist or has been disabled' on every authenticated request. Inject UpdateCheckService and short-circuit getCurrentUser when userGuid matches the install_id, returning a transient in-memory admin User that satisfies RBAC checks without a database lookup.
The install_id login flow produces a transient admin user that is never persisted to the user table, so AdminGuard's database lookup always missed and rejected the request with 403. Resolve the system install_id from system_settings and treat it as an administrator before falling back to the database check.
The warn log on install_id lookup failure was unnecessary noise; failures now fall back silently to the regular database check.
hashbk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.