Add the guest cluster loadbalancer network resolution#1064
Open
w13915984028 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation describing how Harvester resolves the target network for guest-cluster LoadBalancer Services, and links that guidance from the Rancher cloud provider page to help users in multi-network / shared-namespace scenarios.
Changes:
- Link from the Rancher cloud-provider “IPAM / Pool” section to the new network-resolution documentation.
- Add a new “Guest Cluster Load Balancer Network Resolution” section to the IPPool documentation describing the webhook’s resolution order (legacy vs current behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/rancher/cloud-provider.md | Adds a cross-reference to the new IPPool section so users can find network-resolution behavior details from the LB/IPAM docs. |
| docs/networking/ippool.md | Documents the guest-cluster LB network annotation resolution workflow (legacy vs current). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Signed-off-by: Jian Wang <jian.wang@suse.com>
1d499fa to
766ad10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Guest cluster + LB work together to support named network selection.
Solution:
Update the document after code PR is merged.
Related Issue(s):
harvester/harvester#10381
harvester/harvester#10068
harvester/load-balancer-harvester#103
Test plan:
Additional documentation or context
NOTE: The HCP related feature extensions will be added to document on another PR.