feat(advise): schema-qualified keying, join/group rules, and wrapped reads - #12

Merged

hanslemm merged 25 commits into

mainfrom

feat/advise-batch-2

Jul 27, 2026

Commits on Jul 27, 2026

feat(advise): key column usage by schema-qualified relation

hanslemm
and
claude
committed
83abf4a
fix(advise): pin the DML arity guard, explicit-db validation, and Relation.__str__

hanslemm
and
claude
committed
40c4c92
feat(advise): aggregate per relation, count schema ambiguity separately
hanslemm
committed
3021d78
docs: implementation plan for advise batch 2 (schema keying, join/group rules, unwrapping)
hanslemm
committed
a4d6597
fix(advise): resolve star_tables through resolve_relation, count ambiguous DML targets
hanslemm
committed
d0421d0
feat(advise): key catalog facts and indexes by relation

hanslemm
and
claude
committed
72ba4d4
fix(advise): address Task 3 review findings

hanslemm
and
claude
committed
d9bb1d4
feat(advise): propose per relation, with schema-qualified DDL
hanslemm
committed
3ac0416
fix(advise): pin ADV002-004 evidence contract, attribute ADV006 by parsing
hanslemm
committed
0b169cb
feat(advise): accept multiple --schema, disclose ambiguous statements

hanslemm
and
claude
committed
b6636ea
fix(advise): stop skipped_ambiguous from lying about coverage

hanslemm
and
claude
committed
f87b946
feat(advise): ADV007 -- index the hot join key
hanslemm
committed
77e28ff
fix(advise): ADV007 -- disclose partial/expression indexes, pin confidence ladder
hanslemm
committed
3981ad1
feat(advise): ADV008 -- index to serve a hot GROUP BY
hanslemm
committed
49218b8
fix(advise): ADV008 requires joint co-occurrence, not pairwise-with-seed
hanslemm
committed
0b95d0e
fix(advise): ADV008 drops the plain fingerprints key, joint count only
hanslemm
committed
28f0dd6
fix(advise): collapse colliding index proposals, not just colliding DDL

hanslemm
and
claude
committed
ffccb4b
fix(advise): pin the collapse guards, and stop the folded rationale repeating itself

hanslemm
and
claude
committed
0a081bc
fix(advise): analyse cursor and COPY-subquery reads instead of filtering them
hanslemm
committed
350ec9c
fix(advise): correct the DECLARE cost claim, dedup COPY under track=all
hanslemm
committed
e119452
fix(advise): revert the toplevel filter, document COPY double-count instead
hanslemm
committed
85e6622
test(integration): multi-schema, join/group rules and cursor reads against real postgres
hanslemm
committed
7ac7b95
fix(integration): make the live rule/cursor/sentinel tests actually pin their claims
hanslemm
committed
4b69985
fix(advise): close the whole-branch review's seven findings and five minors

hanslemm
and
claude
committed
d3cb52d
fix(advise): correct the last false docstring, and pin two assertions that passed vacuously

hanslemm
and
claude
committed
3395e87

Navigation Menu

feat(advise): schema-qualified keying, join/group rules, and wrapped reads - #12

feat(advise): schema-qualified keying, join/group rules, and wrapped reads#12
hanslemm merged 25 commits into
mainfrom
feat/advise-batch-2

Commits on Jul 27, 2026

feat(advise): key column usage by schema-qualified relation

fix(advise): pin the DML arity guard, explicit-db validation, and Relation.str

feat(advise): aggregate per relation, count schema ambiguity separately

docs: implementation plan for advise batch 2 (schema keying, join/group rules, unwrapping)

fix(advise): resolve star_tables through resolve_relation, count ambiguous DML targets

feat(advise): key catalog facts and indexes by relation

fix(advise): address Task 3 review findings

feat(advise): propose per relation, with schema-qualified DDL

fix(advise): pin ADV002-004 evidence contract, attribute ADV006 by parsing

feat(advise): accept multiple --schema, disclose ambiguous statements

fix(advise): stop skipped_ambiguous from lying about coverage

feat(advise): ADV007 -- index the hot join key

fix(advise): ADV007 -- disclose partial/expression indexes, pin confidence ladder

feat(advise): ADV008 -- index to serve a hot GROUP BY

fix(advise): ADV008 requires joint co-occurrence, not pairwise-with-seed

fix(advise): ADV008 drops the plain fingerprints key, joint count only

fix(advise): collapse colliding index proposals, not just colliding DDL

fix(advise): pin the collapse guards, and stop the folded rationale repeating itself

fix(advise): analyse cursor and COPY-subquery reads instead of filtering them

fix(advise): correct the DECLARE cost claim, dedup COPY under track=all

fix(advise): revert the toplevel filter, document COPY double-count instead

test(integration): multi-schema, join/group rules and cursor reads against real postgres

fix(integration): make the live rule/cursor/sentinel tests actually pin their claims

fix(advise): close the whole-branch review's seven findings and five minors

fix(advise): correct the last false docstring, and pin two assertions that passed vacuously