detect/prevent Func vs input name collisions#9145
Open
abadams wants to merge 1 commit into
Open
Conversation
ImageParams already reserved their name against later Funcs via a call
to unique_name in create_func. Do the same for Generator Input<>s
(buffer and scalar) in init_internals, and for named scalar Params in
check_name, so that a Func declared with the same name afterward gets
a distinct unique name instead of silently colliding.
For the reverse ordering (Func declared first), names can no longer be
fixed up, so validate the environment in build_environment: if any
input buffer or scalar Parameter shares a name with a Func in the
pipeline, emit a clear user_error instead of crashing deeper in
lowering. Output Funcs are exempted from the buffer check since they
intentionally share names with their output buffer Parameters.
Tests:
- correctness/input_func_name_unique exercises the three reservation
paths (ImageParam, Param, Generator Input<Buffer>).
- error/input_{buffer,param,generator_buffer}_func_name_collision
exercises the three error paths.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9145 +/- ##
=======================================
Coverage ? 69.77%
=======================================
Files ? 255
Lines ? 77564
Branches ? 18545
=======================================
Hits ? 54124
Misses ? 17951
Partials ? 5489 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexreinking
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageParams already reserved their name against later Funcs via a call to unique_name in create_func. Do the same for Generator Input<>s (buffer and scalar) in init_internals, and for named scalar Params in check_name, so that a Func declared with the same name afterward gets a distinct unique name instead of silently colliding.
For the reverse ordering (Func declared first), names can no longer be fixed up, so validate the environment in build_environment: if any input buffer or scalar Parameter shares a name with a Func in the pipeline, emit a clear user_error instead of crashing deeper in lowering. Output Funcs are exempted from the buffer check since they intentionally share names with their output buffer Parameters.
Tests:
Fixes #9142