Don't wrap lambdas pointlessly#9138
Open
abadams wants to merge 2 commits into
Open
Conversation
repeat_edge(imageparam) has *two* wrapper Funcs around it. The imageparam comes with one (accessible via its implicit cast to Func operator), and then because it's not exactly a Func, the boundary condition helper adds another one. This commit changes the boundary condition helper to use a class's existing implicit conversion to a Func if there is one, avoiding the pointless extra Func. The else case is still necessary because a Halide::Buffer can be accessed like a Func, but not implicitly cast to a Func.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9138 +/- ##
=======================================
Coverage ? 69.86%
=======================================
Files ? 254
Lines ? 77525
Branches ? 18534
=======================================
Hits ? 54166
Misses ? 17951
Partials ? 5408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repeat_edge(imageparam) has two wrapper Funcs around it, not even counting the repeat_edge Func. The imageparam comes with one (accessible via its implicit cast to Func operator), and then because it's not exactly a Func, the boundary condition helper func_like_to_func adds another one. This commit changes the boundary condition helper to use a class's existing implicit conversion to a Func if there is one, avoiding the pointless extra Func.
The else case is still necessary because a Halide::Buffer can be accessed like a Func, but not implicitly cast to a Func.