Skip to content

Search/Filter Integration: Update Counter and Improve Visual Feedback - #8862

Open
computarisis wants to merge 2 commits into
hackforla:gh-pagesfrom
computarisis:update-counter-improve-visual-feedbck-8467
Open

computarisis wants to merge 2 commits into
hackforla:gh-pagesfrom
computarisis:update-counter-improve-visual-feedbck-8467

Conversation

@computarisis

@computarisis computarisis commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Fixes #8467

What changes did you make?

  • Modified the code to integrate any expressions (possibly multiple, not just a single one) from search bar into the filter bar
  • Modified the code to allow the counter to increment when there are search terms
  • Added container element to display filter keywords without having to reopen filter bar (for mobile)

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Details im1 im5 im2 im3 im4

Note: I went for not posting photos of the 'before changes are applied' state because I don't think these would help elucidate the issue (it might actually have the opposite effect).

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b computarisis-update-counter-improve-visual-feedbck-8467 gh-pages
git pull https://github.com/computarisis/website.git update-counter-improve-visual-feedbck-8467

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Large Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ Feature: Refactor HTML size: 2pt Can be done in 7-12 hours HLC: M Homepage Launch Countdown Must Have labels Nov 6, 2026
@computarisis
computarisis requested review from Tomomi-K1 and removed request for Tomomi-K1 November 9, 2026 13:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor HTML HLC: M Homepage Launch Countdown Must Have P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Search/Filter Integration: Update Counter and Improve Visual Feedback

1 participant