Skip to content

ER: Blank PRs get commented on for formatting issues too #8871

Open

Description

@meghan-oconnell

Emergent Requirement - Problem

We should make sure that check-linked-issue.js can handle blank PRs as well. That code currently helps to check PRs for proper formatting to make sure an issue is linked, but it fails if the PR it is checking is blank.

Issue you discovered this emergent requirement in

Date discovered

10-24-2026

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@castillios
@daras-cu

What happens if this is not addressed

If a blank PR get published, the PR to check for a a properly linked issue does not leave any comment on the PR to notify the author of an issue.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Issue:

  • Complexity: Small (While the suggested change here only requires changing one line of code, I gave it the Complexity: Small label because it requires testing GitHub Actions.)
  • Relationships: None
  • Size: 0.25pt
  • Fix:
    in ~/github-actions/trigger-pr/check-linked-issue.js (line 105), change:
const match = pr.body.match(regex); 

... to:

const match = (pr.body ?? '').match(regex);

Activity

  1. added
    Complexity: SmallTake this type of issues after the successful merge of your second good first issue
    Feature: Refactor GHARefactoring GitHub actions to fit latest architectural norms
    size: 0.25ptCan be done in 0.5 to 1.5 hours
    EREmergent Request
    on Nov 11, 2026
  2. added
    ready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritization
    on Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Complexity: SmallTake this type of issues after the successful merge of your second good first issueEREmergent RequestFeature: Refactor GHARefactoring GitHub actions to fit latest architectural normsIssue Making: Level 2Make issue(s) from an ER or Epicready for merge teamneeds a senior review either to do some re writing or to approve it for ready for prioritizationrole: back end/devOpsTasks for back-end developerssize: 0.25ptCan be done in 0.5 to 1.5 hours

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions