Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203.
Adds an
aws_s3_bucket_lifecycle_configurationto each CloudTrail log bucket interraform/cloudtrail.tf: expire objects after 365 days, abort incomplete multipart uploads after 7. Expiration only — no storage-class transition, since these objects are far below Glacier's 128 KB minimum billable size. Neither bucket has ever had versioning enabled, so no noncurrent-version rule is needed. The file header comment is updated to drop the lifecycle configuration from its list of deliberately omitted items.Expected plan: 2 to add, 0 to change, 0 to destroy.
Before merging: the first expiration sweep permanently deletes roughly 2022-10 to 2025-11 of management-events history. Confirm nobody relies on it.
terraform/README.mdis not regenerated here — it is already behindmainand is left for #208.