Skip to content

Feature: checkout frontend#91

Open
martin0024 wants to merge 12 commits into
developfrom
feature/checkout-frontend
Open

Feature: checkout frontend#91
martin0024 wants to merge 12 commits into
developfrom
feature/checkout-frontend

Conversation

@martin0024
Copy link
Copy Markdown
Contributor

Closes #69

Overview

Implemented the checkout flow (for private lessons and programs)
WIP on subscriptions and calendar

Screenshots / Screencasts

image

Checklist

  • Code is neat, readable, and works
  • Code is commented where appropriate and well-documented
  • Commit messages follow our guidelines
  • Issue number is linked
  • Branch is linked
  • Reviewers are assigned (one of your tech leads)

@martin0024 martin0024 force-pushed the feature/checkout-frontend branch from 805c49f to a96bcbc Compare June 1, 2026 13:46
@martin0024 martin0024 changed the title [DRAFT] Feature/checkout frontend Feature: checkout frontend Jun 4, 2026
@martin0024
Copy link
Copy Markdown
Contributor Author

note: tests are failing because i introduced a new npm package.

Availability sent
</h2>
<p className="mt-1 text-sm text-muted-foreground">
We've emailed {clientName} the {matchCount} matching{" "}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test isn't from a new npm package; it's from the linter telling you you should replace We've with We&apos;ve

Suggested change
We've emailed {clientName} the {matchCount} matching{" "}
We&apos;ve emailed {clientName} the {matchCount} matching{" "}

clientSlots: TimeSlot[];
initialCoachSlots: TimeSlot[];
}) {
const window = React.useMemo(() => deriveWindow(clientSlots), [clientSlots]);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should name the window variable something else; it can be confusing with the window global that the browser provides

Comment on lines +30 to +40
function formatWindow(slot: TimeSlot): string {
const start = new Date(slot.start);
const end = new Date(slot.end);
return `${formatTime(start)} – ${formatTime(end)}`;
}

function formatBookable(slot: TimeSlot): string {
const start = new Date(slot.start);
const end = new Date(slot.end);
return `${formatTime(start)} – ${formatTime(end)}`;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two functions have the exact same body; it could be avoided

Comment on lines +1 to +2
import Link from "next/link";
import { Button } from "@/components/ui/button";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter gives some warning about these being unused, remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants