Feature/65 discount modal#73
Merged
Merged
Conversation
RenaudBernier
requested changes
May 22, 2026
Member
RenaudBernier
left a comment
RenaudBernier
left a comment
There was a problem hiding this comment.
The modal should show the original price of the selected service
martin0024
approved these changes
May 23, 2026
| services={services} | ||
| loading={loading} | ||
| open={open} | ||
| onOpenChange={handleOpenChange} |
Contributor
There was a problem hiding this comment.
re-hits Stripe on every open no caching?
Contributor
There was a problem hiding this comment.
wrap listStripeServices in unstable_cache since service catalogs change rarely, right now on modal open it does 2 stripe api calls products +prices.
martin0024
requested changes
May 23, 2026
Contributor
martin0024
left a comment
martin0024
left a comment
There was a problem hiding this comment.
requested changed, see comments above
…ns in DiscountModal
martin0024
requested changes
May 23, 2026
| onOpenChange?: (open: boolean) => void; | ||
| } | ||
|
|
||
| const TABLE_GRID = "grid grid-cols-[2fr_1fr_1fr_1fr_2.5rem]"; |
Contributor
There was a problem hiding this comment.
Raw HTML instead of components/ui/table.tsx. Table Docs
| services={services} | ||
| loading={loading} | ||
| open={open} | ||
| onOpenChange={handleOpenChange} |
Contributor
There was a problem hiding this comment.
wrap listStripeServices in unstable_cache since service catalogs change rarely, right now on modal open it does 2 stripe api calls products +prices.
martin0024
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Overview
Adds the discount modal
Testing
Manually open and create/delete discounts to see it works
Screenshots / Screencasts
Checklist
Tip: You can make the issue and then check them after the fact or replace
[ ]with[x]to check it!Notes
I've added the font from the Figma file for now, to use within this component, though later on we should change how it's used in this component