Skip to content

chore(deps): update vitest monorepo to v5 - #119

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-vitest-monorepo
Open

chore(deps): update vitest monorepo to v5#119
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-vitest-monorepo

Conversation

@renovate

@renovate renovate Bot commented Sep 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
@vitest/coverage-istanbul (source) 4.1.11 → 5.0.5 age confidence
vitest (source) 4.1.11 → 5.0.5 age confidence

Release Notes

vitest-dev/vitest (@​vitest/coverage-istanbul)

v5.0.5

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.4

Compare Source

   🚀 Features
   🐞 Bug Fixes
   🏎 Performance
    View changes on GitHub

v5.0.3

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.2

Compare Source

   🐞 Bug Fixes
    View changes on GitHub

v5.0.1

Compare Source

   🚀 Features
   🐞 Bug Fixes
    View changes on GitHub

v5.0.0

Compare Source

Vitest 5 is officially out! This release focuses on performance and brings a lot of new features while fixing long-standing bugs. See our blog post for the official announcement.

   🚨 Breaking Changes
   🚀 Features

[!IMPORTANT]
✂ PR body was truncated to here.

Configuration

📅 Schedule: (in timezone Asia/Tokyo)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from h13 as a code owner September 3, 2026 23:00
@renovate
renovate Bot force-pushed the renovate/major-vitest-monorepo branch 27 times, most recently from fcc8a6e to f343125 Compare September 11, 2026 15:34
@renovate
renovate Bot force-pushed the renovate/major-vitest-monorepo branch 25 times, most recently from 60399b8 to 956df20 Compare September 20, 2026 18:54
@h13 Claude

h13 commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Holding this PR open — verified the ecosystem blocker mentioned in Renovate's config rather than assuming it.

What I checked

  • Current vitest is 4.1.11; this PR bumps to 5.0.1. @cloudflare/vitest-pool-workers stays pinned at 0.22.0 (the latest published version) since Renovate has no newer release to offer.
  • @cloudflare/vitest-pool-workers@0.22.0's published peerDependencies are: 
    "vitest": "^4.1.0",
"@vitest/runner": "^4.1.0",
"@vitest/snapshot": "^4.1.0"
    i.e. it does not declare support for vitest 5, and no 0.23.x/1.x release exists yet on npm that does.
  • pnpm install does not hard-fail on the peer mismatch (pnpm tolerates it here), so the conflict doesn't surface at install time. But it does surface at runtime: pnpm run test on this branch fails on every worker-pool test file: 
    Error: [vitest-pool]: Failed to start cloudflare-pool worker for test files ...
Caused by: SyntaxError: Unexpected identifier 'file'
  at ProxyServer.fetch node_modules/.pnpm/miniflare@.../miniflare/src/workers/core/proxy.worker.ts:173:11
    All 9 test files that use the Workers pool fail to even start (9 errors, 0 tests run). This matches the check job failure on this PR's CI run.

Conclusion: this is a genuine, current incompatibility between @cloudflare/vitest-pool-workers@0.22.0 and vitest@5.x, not a flake — it needs a @cloudflare/vitest-pool-workers release that supports vitest 5 before this can be merged. Leaving this open with the breaking label until that's available upstream. Please re-run this triage once a newer @cloudflare/vitest-pool-workers is released with a vitest: ^5 peer range.

Generated by Claude Code

@h13 Claude

h13 commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Holding — do not merge. Verified the known org policy directly.

@cloudflare/vitest-pool-workers@0.22.0 (currently pinned in package.json/pnpm-lock.yaml) declares:

peerDependencies:
  '@vitest/runner': ^4.1.0
  '@vitest/snapshot': ^4.1.0
  vitest: ^4.1.0

This PR bumps vitest and @vitest/coverage-istanbul from 4.1.11 to 5.0.2, which falls outside that ^4.1.0 peer range.

Reproduced locally (checked out renovate/major-vitest-monorepo, pnpm install --frozen-lockfile, pnpm run test): every test file that goes through the Cloudflare Workers pool fails immediately:

Error: [vitest-pool]: Failed to start cloudflare-pool worker for test files ...
Caused by: SyntaxError: Unexpected identifier 'file'
  at ProxyServer.fetch .../miniflare/src/workers/core/proxy.worker.ts:173:11

9/9 test files errored, 0 tests ran. This matches the org-wide guidance: @cloudflare/vitest-pool-workers peer deps lag behind new vitest majors, so this v5 bump is not safe to merge yet.

Leaving this open until @cloudflare/vitest-pool-workers ships a release supporting vitest ^5. No code fix on our side addresses this — it's an upstream peer-dependency gap.

Generated by Claude Code

@h13 Claude

h13 commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Not merging: @cloudflare/vitest-pool-workers (used by this repo, currently 0.22.0, latest on npm) declares peer dependencies vitest ^4.1.0, @vitest/runner ^4.1.0 and @vitest/snapshot ^4.1.0, so vitest 5 is unsupported. Also the check job is failing. Keeping open until pool-workers publishes a release supporting vitest 5.

Generated by Claude Code

@h13 Claude

h13 commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Renovate の vitest 5 メジャー更新は merge を保留します。

  • @cloudflare/vitest-pool-workers@0.23.0 の peerDependencies が vitest ^4.1.0 (@vitest/runner / @vitest/snapshot も ^4.1.0) で、vitest 5 に未対応です。
  • 本ブランチで pnpm test を実行すると、miniflare の pool が SyntaxError: Unexpected identifier 'file' で起動に失敗し、テストが 0 件のままエラーになります (check 失敗の原因)。
  • @cloudflare/vitest-pool-workers が vitest 5 に対応するまでは tsconfig / workflow の追随では解消できないため、open のまま残します。対応版の公開後に再評価してください。

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h13 h13 Awaiting requested review from h13 h13 is a code owner

Assignees

No one assigned

Labels

breaking dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@h13