Repository navigation
chore(core): neutralize our hosts out of the runnable Core defaults - #42
Draft
guycochran wants to merge 1 commit into
Draft
guycochran wants to merge 1 commit into
guycochran wants to merge 1 commit into
Conversation
…Core-vs-Skin discipline) Guy's principle: the Core is for everyone; OUR deployment specifics belong in a Skin or stay private. The runnable Core (backend/scripts/tools) defaulted its env vars to our hosts (MXL_BACKEND_URL=https://prodbots.com, MXL_FEED_URL=https://mxl-feed.cochran.cloud, etc.). Even as overridable defaults, a stranger cloning the Core shouldn't see our infrastructure. Now the defaults are neutral (http://localhost:3013 / :8889, YOUR-*-HOST in comments), still overridable via the same MXL_* env vars — our box sets them, so nothing changes for us. Shrank the hardcoded-host tripwire allowlist accordingly (ratchet) and updated test_env_config to pin the new neutral defaults. NOTE: docs/ (the mxlswitcher.com site) KEEPS its 'Office Hours Global' bylines + our findings — that's OUR publication, correctly ours, not a leak. This change is only the runnable Core. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GwSKEZZz4yEc2CGq5hcTmT
guycochran
added a commit
that referenced
this pull request
Oct 9, 2026
…Core-neutralization (PR #42) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GwSKEZZz4yEc2CGq5hcTmT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guy's Core-vs-Skin call (Oct 9): the Core is for everyone; our deployment specifics belong in a Skin or stay private.
The runnable Core (backend/scripts/tools) defaulted its env vars to our hosts —
MXL_BACKEND_URL=https://prodbots.com,MXL_FEED_URL=https://mxl-feed.cochran.cloud, plus comment/docstring references. Even as overridable defaults, a stranger cloning the Core shouldn't see our infrastructure.This PR: defaults are now neutral (
http://localhost:3013/:8889,YOUR-*-HOSTin prose), still overridable via the sameMXL_*env vars — our box sets them, so nothing changes operationally for us. Shrank thetest_no_hardcoded_hostsallowlist (ratchet) and updatedtest_env_configto pin the neutral defaults.Deliberately NOT touched:
docs/(the mxlswitcher.com site) keeps its "Office Hours Global" bylines + our findings — that's our publication, correctly ours, not a leak.Full suite green. Complements the #41 hostname-removal + mediamtx-API-localhost hardening.
Suggest merging early in the sequence (it's small, master-based, no conflicts).
🤖 Generated with Claude Code