Repository navigation
Replace the installer's package manager firehose with one line per step - #8
Merged
Merged
Conversation
`apt-get update` prints about sixty lines of repository chatter — InRelease
fetches, signature warnings from unrelated third-party repositories, byte
counts. None of it says whether the install is going well, and it buries the
lines that do.
Long steps now draw a single line with a spinner and an elapsed counter,
replaced by a tick when they finish:
✔ Refreshing package lists (6s)
✔ Installing 5 system packages (11s)
✔ Installing motionless (9s)
The output is captured, not discarded. A step that fails prints everything it
produced, indented, so the detail is there exactly when it is wanted and
absent when it is not. Without a terminal the whole thing degrades to plain
lines with no animation, so piped output and CI logs stay readable.
Two things this deliberately does not do. It never wraps something that can
prompt: a password prompt drawn over by a spinner is invisible, which is the
failure this installer already shipped once. sudo is primed before any spinner
starts, and steps that need root use a runner that cannot prompt. And it shows
no percentage, because neither apt nor pipx reports progress and a bar that
invents one is a lie told at the moment the user is deciding whether to trust
the thing.
Verified under a real pty for the success and failure paths, and piped for the
non-terminal path. The failure run caught a bug in the first draft of the
no-prompt runner: it folded the credential check into the command, so apt
exiting 100 was reported as expired sudo credentials. The two are now checked
separately and the command's own status reaches the caller.
guilyx
marked this pull request as ready for review
September 15, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
apt-get updateprints about sixty lines of repository chatter — InRelease fetches, byte counts, signature warnings from unrelated third-party repositories. None of it says whether the install is going well, and it buries the lines that do.Long steps now draw a single line with a spinner and an elapsed counter, replaced by a tick when they finish.
Before
After
Nothing is hidden
The output is captured, not discarded. A step that fails prints everything it produced, indented, so the detail arrives exactly when it is wanted:
Without a terminal — piped output, CI logs — it degrades to plain lines with no animation and no escape sequences.
Two things it deliberately does not do
It never wraps something that can prompt. A password prompt drawn over by a spinner is invisible, and that is the failure this installer already shipped once in #6. sudo is primed before any spinner starts, and steps needing root go through a runner that cannot prompt — if the credentials have lapsed it fails immediately and visibly rather than waiting on a prompt nobody can see.
It shows no percentage. Neither apt nor pipx reports progress, so a bar would have to invent one. A fake progress bar is a lie told at the moment the user is deciding whether to trust the thing, so the elapsed counter is the honest version: it conveys "still working, this long so far" without claiming to know the end.
How it was tested
Driven under a real pty with stub
sudo,apt-get,pipxandmotionlesson PATH, and the captured stream replayed through a small renderer that emulates carriage returns, so the final visible state could be checked rather than the raw escape soup:::and✔lines, no animation.shellcheckandbash -nclean.The failure run earned its keep — it caught a bug in the first draft of the no-prompt runner.
sudo -n "$@" || die "sudo credentials expired"folded the credential check into the command, soapt-getexiting 100 was reported as expired sudo credentials. Misattributing a package manager failure to sudo is the same class of misleading error as the CI message I had to rewrite in #7. The check is now separate and the command's own exit status reaches the caller unchanged.shellcheck install.shandbash -npassChecklist
CHANGELOG.mdupdated under## [Unreleased]Notes for review
✔,✘and—, so UTF-8 was assumed before this.