Skip to content

Consolidate workflow patterns with bounded correction and recovery - #106

Merged
groupthinking merged 7 commits into
masterfrom
codex/absorb-wrkflw-and-workflows
Oct 30, 2026
Merged

groupthinking merged 7 commits into
masterfrom
codex/absorb-wrkflw-and-workflows

Conversation

@Codex

@Codex Codex AI commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

The original consolidation loaded a few templates but did not carry across the complete workflow patterns or reliably recover failed work. This change consolidates the source contracts, executable patterns and examples from WRKFLW, workflows and the native executor, with bounded correction that preserves successful work and original inputs.

  • Preserve all 18 recorded source blobs and the complete original TypeScript types. The source-to-implementation matrix is in docs/workflows/IMPORTED_PATTERNS.md.
  • Implement source intake, summary/planning, validated BuildPlan DAG execution, five agent kinds, configured MCP/A2A/AP2 client contracts, actual typed scaffold generation and durable status/artifacts.
  • Implement authenticated project/invitation, offline media/log synchronization, task/RFI history, retrieval/embedding/search, cited summary draft, PM review and PDF publication patterns through explicit host adapters.
  • Preserve opt-out, independent per-step policies, positive attempt counts and failure history. Actual repairs change failed technical inputs; no-op repairs fail. Completed siblings/earlier children are checkpointed, and observer/output-binding failures cannot replay completed effects.
  • Preserve every field in an authenticated construction action during adapter repair. A repair may add technical settings but cannot replace notification content, project scope, recipients or attachment targets.
  • Incorporate current master MCP/security/test-entrypoint corrections and repair all eight original inline findings, including pytest compatibility, the WRKFLW tag and runnable documentation imports.

Validation on head e0fd643d37ca3b86f49ccea048faa7153f55fe80:

  • Actual hosted Python CI: 135 passed, 3 existing integration skips, 2 warnings, on both Python 3.10 and 3.11; Black checks all 115 files. Local runs agree.
  • Independent review exercised 70 affected non-construction tests, exact archived source/type provenance and generated TypeScript compilation/execution. A separate lifecycle review executed all 16 lifecycle cases.
  • All 13 current-head checks finished: 12 successful, 1 CodeRabbit skip. CodeQL reports no new alerts in changed code. Existing advisory-only flake8 output is not counted as a clean lint result.
  • Both source repositories were observed archived. Controlled tests perform real local SQLite/file/HTTP/signing/vector/PDF and registered-client work; no paid model, live email, cloud storage, payment or deployment outcome is claimed.

Host application bindings remain required for identity, explicit action confirmation, external services and business handlers. SQLite is a local store; completed-child checkpoints are per execution, not cross-process or distributed transactions. Generated artifacts remain scaffold_only. This is workflow-pattern migration, not recreation of the archived SaaS/mobile interfaces or a repository-wide vulnerability certification.

GitHub's pre-existing squash auto-merge setting merged the reviewed head as 05e47c4b40bf5f9838fd1b837571afd283690bca after its required checks. The merged tree 09f06a50790229b7b88a79da1cbe4283ff08c739 was independently confirmed identical to the reviewed candidate.

Original prompt

This section details on the original issue you should resolve

<issue_title>🔴 Absorb WRKFLW and workflows repos — become the canonical workflow engine</issue_title>
<issue_description>## Problem
3 workflow execution repos:

  • self-correcting-executor (1.3MB, 15 issues) — THIS REPO, has auto-fix capability
  • WRKFLW (451KB, 14 issues) — TypeScript workflow engine
  • workflows (156KB, 1 issue) — TypeScript workflow definitions

Unique Value

self-correcting-executor's auto-fix capability is the differentiator — workflows that detect failures and self-heal. WRKFLW and workflows have generic workflow definitions that should be absorbed.

Plan

  1. Port WRKFLW's workflow templates into self-correcting-executor
  2. Port workflows' definitions as examples
  3. Archive both source repos

Acceptance Criteria

  • All workflow patterns from 3 repos consolidated here
  • Self-correction engine wraps imported workflow types
  • WRKFLW and workflows archived</issue_description>

Comments on the Issue (you are @codex[agent] in this section)

@Codex Codex AI changed the title [WIP] Absorb WRKFLW and workflows repos into self-correcting-executor Consolidate workflow templates with self-healing orchestration Mar 20, 2026
@Codex
Codex AI requested a review from groupthinking March 20, 2026 11:23
@groupthinking
groupthinking marked this pull request as ready for review March 20, 2026 18:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Consolidates workflow templates from external repos into a new workflows package and integrates template selection + self-healing retries into OrchestrationEngine, along with supporting docs and tests.

Changes:

  • Added a declarative workflow template catalog + registry helpers (workflows/) and wired template materialization into orchestration.
  • Implemented step-level retry/self-heal behavior and failure recording hooks during workflow execution.
  • Added documentation and tests validating template coverage and orchestrator template selection; updated test dependencies for async tests.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
workflows/templates.py Introduces WorkflowTemplate and consolidated template definitions.
workflows/self_correcting.py Adds helper to apply retry policy defaults to workflow steps.
workflows/registry.py Provides template listing, intent-to-template matching, and materialization.
workflows/init.py Exposes registry functions as package API.
orchestrator.py Integrates template generation, applies self-correction, adds retry loop + failure recording.
tests/test_workflow_templates.py Adds tests for template sources, materialization, and orchestrator selection.
tests/test_mcp_compliance.py Adjusts MCP fixtures to be synchronous.
tests/conftest.py Ensures repo root is on sys.path for test imports.
requirements-test.txt Adds pytest-asyncio to test requirements.
mcp_server/real_mcp_server.py Adds tool registry + lightweight RealMCPServer wrapper for tests.
docs/workflows/CONSOLIDATION.md Documents consolidation and template-driven orchestration usage.
README.md Mentions the new consolidated workflow catalog.
MCP_INTEGRATION_PLAN.md Clarifies “no mocks” policy statement.
config/init.py Adds config package marker.
.github/dependabot_test.py Adds helper module used by tests for dependabot config assertions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread requirements-test.txt Resolved
Comment thread workflows/self_correcting.py Resolved
Comment thread workflows/templates.py Resolved
Comment thread workflows/templates.py Resolved
Comment thread orchestrator.py Resolved
Comment thread orchestrator.py Resolved
Comment thread docs/workflows/CONSOLIDATION.md Resolved
@Codex Codex AI changed the title Consolidate workflow templates with self-healing orchestration Auto-load workflow templates and tighten PR template Mar 20, 2026
@Codex
Codex AI requested a review from groupthinking March 20, 2026 18:42
Comment thread orchestrator.py Resolved
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@groupthinking
groupthinking merged commit 05e47c4 into master Oct 30, 2026
12 checks passed
@groupthinking
groupthinking deleted the codex/absorb-wrkflw-and-workflows branch October 30, 2026 01:04
@groupthinking groupthinking changed the title Auto-load workflow templates and tighten PR template Consolidate workflow patterns with bounded correction and recovery Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants