Harden Vitest backend env isolation for v0 project config parity - #1813
Open
groupthinking with Copilot wants to merge 2 commits into
Open
Harden Vitest backend env isolation for v0 project config parity#1813groupthinking with Copilot wants to merge 2 commits into
groupthinking with Copilot wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update project files to reflect latest generated configuration
Harden Vitest backend env isolation for v0 project config parity
Sep 8, 2026
groupthinking
approved these changes
Sep 9, 2026
groupthinking
marked this pull request as ready for review
September 9, 2026 18:35
🔍 PR Validation |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
🟢 Approved
The changes are narrowly scoped to test configuration and add a matching regression guard, with no production behavior impact and clear alignment to the stated hermeticity goal.
Pull request overview
This PR hardens apps/web Vitest hermeticity by ensuring NEXT_PUBLIC_* backend URL environment variables cannot leak in from a developer shell or CI, aligning test behavior with v0-style project configuration and keeping route tests deterministic.
Changes:
- Pinned
NEXT_PUBLIC_BACKEND_URLandNEXT_PUBLIC_API_URLto''inapps/web/vitest.config.ts(alongside existingBACKEND_URLpin). - Extended the env isolation regression test to assert both
NEXT_PUBLIC_*vars are blank by default.
File summaries
| File | Description |
|---|---|
| apps/web/vitest.config.ts | Blanks NEXT_PUBLIC_* backend env vars during Vitest runs to prevent ambient leakage. |
| apps/web/src/tests/test-env-isolation.test.ts | Adds regression assertions that NEXT_PUBLIC_BACKEND_URL and NEXT_PUBLIC_API_URL are pinned to ''. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked automatically by the system.
Outcome
This PR closes a project-file gap where
NEXT_PUBLIC_*backend URLs could leak from shell/CI into web tests, causing non-hermetic behavior despite local test defaults.Result: web route tests now stay deterministic under v0-style environment configuration.
Scope
NEXT_PUBLIC_BACKEND_URLandNEXT_PUBLIC_API_URLto''in/apps/web/vitest.config.ts(alongside existingBACKEND_URLpin)./apps/web/src/__tests__/test-env-isolation.test.tsto assert bothNEXT_PUBLIC_*backend env vars are blank by default.Risk
NEXT_PUBLIC_*backend vars.apps/web/vitest.config.ts,apps/web/src/__tests__/test-env-isolation.test.ts).Verification
List exact automated and manual checks, tied to the current head SHA.
Production evidence
Not applicable: change is limited to test configuration and test assertions.
Agent handoff